Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support uBO's filter rules #1

Closed
3 tasks done
ameshkov opened this issue Oct 13, 2020 · 0 comments
Closed
3 tasks done

Feature Request: Support uBO's filter rules #1

ameshkov opened this issue Oct 13, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ameshkov
Copy link
Member

@gontazaka commented on Sun Oct 11 2020

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

||example.com^$3p doesn't work.

Proposed Solution

Support rules $3p, $first-party and $1p.
I can substitute it with $third-party, but I don't want to modify existing filter.

Additional Information

$3p are the equivalent to $third-party.
https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#3p

$first-party and $1p are the equivalent to $~third-party.
https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#first-party
https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#1p

The impact on implementation will be minimal.
https://github.com/AdguardTeam/AdguardForiOS/blob/v4.0.3/AdguardExtension/SharedComponents/Services/JSConverter.js#L2640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants