Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible package update - globals #12496

Open
lukemckinstry opened this issue Feb 25, 2025 · 3 comments
Open

Incompatible package update - globals #12496

lukemckinstry opened this issue Feb 25, 2025 · 3 comments
Labels
dependencies Relating to our package dependencies priority - next release

Comments

@lukemckinstry
Copy link
Contributor

What happened?

Incompatible npm

npm outdated -->

Package   Current   Wanted  Latest  Location               Depended by
globals   15.15.0  15.15.0  16.0.0  node_modules/globals   cesium

npm install globals@latest -->

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/globals
npm WARN   peer globals@"^15.0.0" from [email protected]
npm WARN   node_modules/eslint-config-cesium
npm WARN     dev eslint-config-cesium@"^11.0.1" from the root project
npm WARN   2 more (eslint-plugin-n, the root project)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer globals@"^15.0.0" from [email protected]
npm WARN node_modules/eslint-config-cesium
npm WARN   dev eslint-config-cesium@"^11.0.1" from the root project

added 1 package, changed 1 package, and audited 742 packages in 1s

158 packages are looking for funding
  run `npm fund` for details

5 vulnerabilities (2 moderate, 3 high)

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

npm install -->

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/globals
npm ERR!   dev globals@"^16.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer globals@"^15.0.0" from [email protected]
npm ERR! node_modules/eslint-config-cesium
npm ERR!   dev eslint-config-cesium@"^11.0.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/globals
npm ERR!   peer globals@"^15.0.0" from [email protected]
npm ERR!   node_modules/eslint-config-cesium
npm ERR!     dev eslint-config-cesium@"^11.0.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /home/lukemckinstry/.npm/_logs/2025-02-25T18_57_13_720Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/lukemckinstry/.npm/_logs/2025-02-25T18_57_13_720Z-debug-0.log

Reproduction steps

...

Sandcastle example

No response

Environment

Browser:
CesiumJS Version:
Operating System:

@ggetz
Copy link
Contributor

ggetz commented Feb 25, 2025

@lukemckinstry We'll need to update https://github.com/CesiumGS/eslint-config-cesium and publish a new version. Then we can install that and the new version of globals.

Would you be able to open a PR over in eslint-config-cesium?

@lukemckinstry
Copy link
Contributor Author

Would you be able to open a PR over in eslint-config-cesium?

Opened the PR here CesiumGS/eslint-config-cesium#8

I'm not sure the release process once it gets merged

@ggetz
Copy link
Contributor

ggetz commented Feb 25, 2025

@lukemckinstry Happy to help once we merge that PR.

@ggetz ggetz added dependencies Relating to our package dependencies priority - next release and removed type - bug needs triage labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relating to our package dependencies priority - next release
Projects
None yet
Development

No branches or pull requests

2 participants