Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL result body type #334

Open
kam193 opened this issue Mar 8, 2025 · 5 comments
Open

URL result body type #334

kam193 opened this issue Mar 8, 2025 · 5 comments
Assignees
Labels
accepted This issue was accepted, we will work on this at some point enhancement New feature or request service-virustotal ui-frontend

Comments

@kam193
Copy link

kam193 commented Mar 8, 2025

Is your feature request related to a problem? Please describe.
Services integrating with external services often show a link to results, e.g. VirusTotal:

Image

However, the link is not clickable. You have to mark and copy it to open the website

Describe the solution you'd like
I'd like to have a new result body type designed for URLs that should be clickable (e.g. analysis results, NOT: IoCs). It could either be by normal click or in the context menu. If "just clickable", we may want to first show a popup saying that the user is now leaving AL.

Describe alternatives you've considered

  • Letting the service author configure domains allowed to be in the clickable body, to prevent placing a malicious URL by a mistake.
  • Letting the system administrator disable the feature globally.
  • Letting the system administrator, globally or for each service, the list of allowed domains (in addition, in such case they don't need to show a warning) - this sounds the most reasonable to me

Additional context
Add any other context or screenshots about the feature request here.

@kam193 kam193 added assess We still haven't decided if this will be worked on or not enhancement New feature or request labels Mar 8, 2025
@cccs-rs
Copy link
Contributor

cccs-rs commented Mar 8, 2025

There is a URLSection in the service base that does help facilitate making links clickable:
https://github.com/CybercentreCanada/assemblyline-v4-service/blob/0544fd5c68086a035e32a7f2648225c951271133/assemblyline_v4_service/common/result.py#L285

Adding a popup would be a good extension of this section type on the frontend, we do the same thing with external links for enrichment so I think that should be applicable here as well.

@kam193
Copy link
Author

kam193 commented Mar 8, 2025

How did it happen that I looked for it and have never found? 🤔

But as so, what would you think about making the link in VirusTotal service clickable?

@cccs-rs
Copy link
Contributor

cccs-rs commented Mar 8, 2025

I wouldn't be opposed to the idea, but I think we should probably implement something on the frontend that kind of warns the user that they're leaving AL by clicking on the link 😁

@cccs-rs cccs-rs added service-virustotal accepted This issue was accepted, we will work on this at some point and removed assess We still haven't decided if this will be worked on or not labels Mar 8, 2025
@cccs-rs
Copy link
Contributor

cccs-rs commented Mar 8, 2025

In regards to documentation, that's something I want to auto-generate for anything that's more client facing (ie. service-base, assemblyline_client, assemblyline-service-utilities) akin to ReadTheDocs for other libraries.

But it does require us properly documenting our code (which we should do anyways 🫠)

@kam193
Copy link
Author

kam193 commented Mar 9, 2025

We all write proper docs, every day, for every code. Every. Single. One.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This issue was accepted, we will work on this at some point enhancement New feature or request service-virustotal ui-frontend
Projects
None yet
Development

No branches or pull requests

3 participants