-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL result body type #334
Comments
There is a URLSection in the service base that does help facilitate making links clickable: Adding a popup would be a good extension of this section type on the frontend, we do the same thing with external links for enrichment so I think that should be applicable here as well. |
How did it happen that I looked for it and have never found? 🤔 But as so, what would you think about making the link in VirusTotal service clickable? |
I wouldn't be opposed to the idea, but I think we should probably implement something on the frontend that kind of warns the user that they're leaving AL by clicking on the link 😁 |
In regards to documentation, that's something I want to auto-generate for anything that's more client facing (ie. service-base, assemblyline_client, assemblyline-service-utilities) akin to ReadTheDocs for other libraries. But it does require us properly documenting our code (which we should do anyways 🫠) |
We all write proper docs, every day, for every code. Every. Single. One. |
Is your feature request related to a problem? Please describe.
Services integrating with external services often show a link to results, e.g. VirusTotal:
However, the link is not clickable. You have to mark and copy it to open the website
Describe the solution you'd like
I'd like to have a new result body type designed for URLs that should be clickable (e.g. analysis results, NOT: IoCs). It could either be by normal click or in the context menu. If "just clickable", we may want to first show a popup saying that the user is now leaving AL.
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: