Skip to content

Commit cf1ffa0

Browse files
authored
docs: docsge fix title in <meta> elements (#572)
current docsgen result in broken metatags: ```html <meta name="twitter:title" content=""CycloneDX v1.6 Protobuf Reference""/> <meta name="twitter:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png"/> <meta name="twitter:description" content=""CycloneDX v1.6 Protobuf Reference""/> <meta name="description" content=""CycloneDX v1.6 Protobuf Reference""/> <meta property="og:description" content=""CycloneDX v1.6 Protobuf Reference""/> <meta property="og:title" content=""CycloneDX v1.6 Protobuf Reference""/> ``` this PR fixes this Signed-off-by: Jan Kowalleck <[email protected]>
1 parent a43e6f7 commit cf1ffa0

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

docgen/json/templates/cyclonedx/base.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
<meta charset="UTF-8"/>
99
<meta name="twitter:card" content="summary_large_image"/>
1010
<meta name="twitter:site" content="@CycloneDX_Spec"/>
11-
<meta name="twitter:title" content="${quotedTitle}"/>
11+
<meta name="twitter:title" content="${title}"/>
1212
<meta name="twitter:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png"/>
13-
<meta name="twitter:description" content="${quotedTitle}"/>
14-
<meta name="description" content="${quotedTitle}"/>
15-
<meta property="og:description" content="${quotedTitle}"/>
16-
<meta property="og:title" content="${quotedTitle}"/>
13+
<meta name="twitter:description" content="${title}"/>
14+
<meta name="description" content="${title}"/>
15+
<meta property="og:description" content="${title}"/>
16+
<meta property="og:title" content="${title}"/>
1717
<meta property="og:locale" content="en_US"/>
1818
<meta property="og:type" content="website" />
1919
<meta property="og:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png" />
@@ -93,4 +93,4 @@ <h1>{{ title }}</h1>
9393
-->
9494

9595
</body>
96-
</html>
96+
</html>

docgen/proto/templates/html.tmpl

+5-5
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ https://github.com/pseudomuto/protoc-gen-doc/blob/master/resources/html.tmpl
1212
<meta charset="UTF-8"/>
1313
<meta name="twitter:card" content="summary_large_image"/>
1414
<meta name="twitter:site" content="@CycloneDX_Spec"/>
15-
<meta name="twitter:title" content="${quotedTitle}"/>
15+
<meta name="twitter:title" content="${title}"/>
1616
<meta name="twitter:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png"/>
17-
<meta name="twitter:description" content="${quotedTitle}"/>
18-
<meta name="description" content="${quotedTitle}"/>
19-
<meta property="og:description" content="${quotedTitle}"/>
20-
<meta property="og:title" content="${quotedTitle}"/>
17+
<meta name="twitter:description" content="${title}"/>
18+
<meta name="description" content="${title}"/>
19+
<meta property="og:description" content="${title}"/>
20+
<meta property="og:title" content="${title}"/>
2121
<meta property="og:locale" content="en_US"/>
2222
<meta property="og:type" content="website" />
2323
<meta property="og:image" content="https://cyclonedx.org/images/CycloneDX-Social-Card.png" />

0 commit comments

Comments
 (0)