Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Error Showen #1090

Closed
2 tasks done
Gepardgame opened this issue Nov 18, 2024 · 4 comments · Fixed by #1091
Closed
2 tasks done

No Error Showen #1090

Gepardgame opened this issue Nov 18, 2024 · 4 comments · Fixed by #1091
Labels
defect Something isn't working
Milestone

Comments

@Gepardgame
Copy link
Contributor

Current Behavior

In the welcome Message admin page, if a error occurs in the backend for processing the message, it will not be showen.

Steps to Reproduce

  1. Be admin
  2. Enable Welcome Message
  3. Enter a very long message over 1024 chars, which will lead to return status 400
  4. Wonder why still the banner is green

Expected Behavior

It should be showen that an error occured

Dependency-Track Frontend Version

4.13.0-SNAPSHOT

Browser

Other

Browser Version

/

Operating System

Other

Checklist

@msymons
Copy link
Member

msymons commented Nov 26, 2024

@Gepardgame...

Enter a very long message over 1024 chars, which will lead to return status 400

I had not even realized that this limitation existed. Would it not be useful to display a (dynamic) character count when editing?

eg, "557/1024"

The 557 in my example is actually the length of my own welcome message. It looks pretty short when rendered, but a lot of the total length comes from URLs that are included in the message.

ie, I could well imagine adding a couple more URLs and hitting the limit. Thus, the utility of having an in-line character count

@Gepardgame
Copy link
Contributor Author

@msymons I added a PR on Alpine, which should allow, to store it in a Clob, meaning where would be no limits anymore.

When you add some extra urls or some custom css/html you get to the limit pretty fast, whats the reason why I raised the PR, cause we wanted to a message longer than the limit.

@fupgang
Copy link
Contributor

fupgang commented Dec 16, 2024

This is actually not fixed for version 4.12.2.
The v4122Updater does not alter the type of the PROPERTYVALUE column to CLOB.
This was suggested in stevespringett/Alpine#722 but didn't make it into the release:

Note that we will need a migration in Dependency-Track for existing databases

@nscuro
Copy link
Member

nscuro commented Dec 16, 2024

@fupgang This particular issue was about no error message being displayed when the error in question was encountered. So users wouldn't know that their change wasn't accepted.

The PR you linked fixes the underlying issue, but was merged after DT v4.12.2 was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants