Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Version Picker Should Indicate Inactive Versions #844

Closed
2 tasks done
msymons opened this issue May 6, 2024 · 6 comments · Fixed by #862
Closed
2 tasks done

Project Version Picker Should Indicate Inactive Versions #844

msymons opened this issue May 6, 2024 · 6 comments · Fixed by #862
Labels
enhancement New feature or request good first issue Good for newcomers p3 Nice-to-have features size/S Small effort
Milestone

Comments

@msymons
Copy link
Member

msymons commented May 6, 2024

Current Behavior

When viewing a project, one can switch to a different version of the project using a dropdown picker. The list of available versions does not indicate which are active and which are inactive

image

Proposed Behavior

The list of versions displayed in the version picker dropdown should indicate when a version is inactive. Perhaps by using strikethrough?

Checklist

@msymons msymons added enhancement New feature or request p3 Nice-to-have features labels May 6, 2024
@nscuro
Copy link
Member

nscuro commented May 8, 2024

Note, the API will need to be updated to include the active field.

The code for querying the version information displayed in this dropdown is here: https://github.com/DependencyTrack/dependency-track/blob/06e6eba67e67fa173a7b1ea46b46515962e61b13/src/main/java/org/dependencytrack/persistence/ProjectQueryManager.java#L1209-L1215

@aravindparappil46
Copy link
Contributor

Hi folks,
I started working on this and wanted to discuss two possible options:

Option 1 - Warning Icon

image

Option 2 - Strikethrough

image

I'm leaning towards Option 1, since

Eager to know your thoughts!

@nscuro
Copy link
Member

nscuro commented May 10, 2024

@aravindparappil46 I think using ⚠️ might be confusing on first look, since we also use that to point out outdated versions. Also, a project being inactive is not something that requires attention, it's more of a BAU thing if that makes sense.

Perhaps using a "muted" text style would make sense, indicating that those items are less important than the rest. We could further sort the version list such that inactive versions are grouped towards the bottom of the dropdown.

Another option - note that I haven't looked at how the dropdown is currently implemented - could be to use b-dropdown-group to provide a clear separation between active and inactive versions: https://bootstrap-vue.org/docs/components/dropdown#b-dropdown-group

@aravindparappil46
Copy link
Contributor

That makes sense, @nscuro . Thanks!

I really liked the last option of adding a group for inactive versions, so went with that in the PR #862 (can make changes, of course).

Here is how it looks:
image

@nscuro nscuro added this to the 4.12 milestone May 11, 2024
@mieliespoor
Copy link

Would it be a manual action then to set the version inactive? In other words, it would be a deliberate decision to set a version inactive, and if you don't, you will have multiple versions active?

@msymons
Copy link
Member Author

msymons commented May 12, 2024

@mieliespoor

Would it be a manual action then to set the version inactive?

Yes. In the UI, this is set via the dialog displayed when clicking the "View Details" button for a project. Flagging a project as inactive is a great way to ensure that it does not "pollute" the portfolio metrics.

The justification for why a project version might be flagged as inactive rather than simply being deleted will depend on your processes/preferences. But note that incoming regulation in Europe will mandate that such data be retained for 10 years AFTER a product is EOL. Thus, the use of "inactive" in DT will most likely increase in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers p3 Nice-to-have features size/S Small effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants