(react-hooks) prefer exported function instead of block-scoped variable #904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the definition of React Hooks to use
export function
instead ofexport const
. It's a simple change that allow developers later to interact better with the signature of the hooks.In TS, these
const
are defined as block-scoped variables, and cannot be overwritten/redefined/overloaded by external TS libraries or consumers.You can see a real-time example for that here , and it's also reported as issue
I'm working on a new plugin for https://github.com/dotansimha/graphql-code-generator , and I would like to extend
urql
behaviour with module augmentation - but at the moment it's not possible because of the way the hooks are defined.Set of changes
Changed
export const
to beexport function
in all React Hooks.