(core) - Strip whitespace from query for GET requests #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 538ffe2 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wgolledge
reviewed
Jul 17, 2020
| @@ -49,7 +49,9 @@ export const makeFetchURL = ( | |||
| } | |||
|
|
|||
| if (body.query) { | |||
| search.push('query=' + encodeURIComponent(body.query)); | |||
| search.push( | |||
| 'query=' + encodeURIComponent(body.query.replace(/[\s,]+/g, ' ').trim()) | |||
There was a problem hiding this comment.
How come we replace with a space? Also is it risky to remove commas?
There was a problem hiding this comment.
The Graphql Query spec only needs the text to be seperated so we go for the smallest amount of space possible (commas aren't enforced)
wgolledge
approved these changes
Jul 17, 2020
kitten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Strips redundant whitespaces when using
GETThis solves the case where the user provides their own queries, ....
Fixes: #907
Set of changes
GET