Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aflaviani Post Symantec Endpoint Security ICDM Connector #63

Closed
wants to merge 4 commits into from

Conversation

aflaviani
Copy link

No description provided.

@aflaviani
Copy link
Author

What does it take to get an approving review?

@ChrisCollinsIBM ChrisCollinsIBM linked an issue Sep 27, 2021 that may be closed by this pull request
@ChrisCollinsIBM
Copy link
Contributor

Hi @aflaviani, could you writeup a README.md to go along with this workflow? I know the Contributing.md doesn't currently ask for it but we'll be updating that soon with some more guidance.

Also could you tidy up some of the XML formatting with indentation based on open/close tags? Helps a LOT for readability and troublshooting.

Thank you.

Copy link
Contributor

@ChrisCollinsIBM ChrisCollinsIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start, I'd just like to get some more detail on the API docs for the product as well as get some of the formatting cleaned up.

Thanks!

@@ -0,0 +1,60 @@
<?xml version="1.0" encoding="UTF-8" ?>
<Workflow name="Symantec Cloud" version="1.0" xmlns="http://qradar.ibm.com/UniversalCloudRESTAPI/Workflow/V1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the workflow name with the detailed product name?


<Actions>
<Initialize path="/next" value="10000000000" />
<Initialize path="/next1" value="11111" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space indentation mixed with previous tab indentation here.



<CallEndpoint url="https://${/host}/v1/event-export" method="POST" savePath="/get_events" >
<RequestHeader name="authorization" value="${/access_token}" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix up the XML tag indentation such that elements within tags are indented as they are opened or closed?

<CallEndpoint url="https://${/host}/v1/event-export" method="POST" savePath="/get_events" >
	<RequestHeader name="authorization" value="${/access_token}" />
	...
	...
</CallEndpoint>

It makes overall readability much better.



<If condition="/get_events/status_code != 200">
<Abort reason="${/get_events/status_code}" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting



<Actions>
<Initialize path="/next" value="10000000000" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some comments or context around what the different values are used for? /next seems to be initialized as a baseline timestamp but looks to be to small to be in milliseconds and too large to be seconds.

For /next1/ not sure what the usage is. The appear to go into a range style parameter in the CallEndpoint but I'd like to see the API doc for the usage to better understand and review.

Could you maybe include a reference to the API documentation for the specific product in a Readme.md?

https://apidocs.securitycloud.symantec.com/#/

</CallEndpoint>

<If condition="/get_access_token/status_code != 200">
<Abort reason="${/get_access_token/body/message}" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting

@ChrisCollinsIBM
Copy link
Contributor

Hi @aflaviani, just wanted to follow up on this pull request.

Overall things look very good but I did have a few questions.

Thanks.

@ChrisCollinsIBM
Copy link
Contributor

This is still an open pull request awaiting changes. @aflaviani when you have a chance to review we'd love to get this merged in, thanks!

@ChrisCollinsIBM
Copy link
Contributor

Changes have been requested prior to merging this workflow, please let me know if you have any questions or require any assistance.

Thanks!

@trizzosk
Copy link

is this in active development or needs to be reactivated again? I need this integration.

@aflaviani
Copy link
Author

aflaviani commented Jan 12, 2023 via email

@trizzosk
Copy link

trizzosk commented Jan 12, 2023

@aflaviani Oki, I saw the announcement abut ICDx which indeed does not support SES streaming API for feeding events to any SIEM system. (link )

However I cannot find any article which you mention above (...we have created and posted a QRadar collector on our website that supersedes this) - any clues how to find it?

@aflaviani
Copy link
Author

aflaviani commented Jan 12, 2023 via email

@karimmms
Copy link

karimmms commented May 14, 2024

Any updates for integrating the export stream API with Qradar Rest API?
We are using an xml workflow that calls the endpoint "v1/event-export/stream/${/stream}/${/channel}", referring to the previous comment, it seems that the Rest API does not support streams, which might be the problem. Using another Symantec API like "/v1/event-search" works fine.

@ChrisCollinsIBM
Copy link
Contributor

ChrisCollinsIBM commented Jun 4, 2024

Any updates for integrating the export stream API with Qradar Rest API? We are using an xml workflow that calls the endpoint "v1/event-export/stream/${/stream}/${/channel}", referring to the previous comment, it seems that the Rest API does not support streams, which might be the problem. Using another Symantec API like "/v1/event-search" works fine.

@karimmms - We've definitely had requests to support the Symantec Streaming API, we're looking at possibly supporting it within this framework but the streaming model doesn't quite line up with the "page at a time" processing that REST calls follow.

We are looking to support this streaming API from Symantec in some way, whether through this framework or a standalone connecter designed to talk to the Symantec Streaming Endpoint specifically but ideally work with multiple products.

@ChrisCollinsIBM
Copy link
Contributor

ChrisCollinsIBM commented Jul 24, 2024

This was initially a proof of concept using the universal collector. Since it's creation we have created and posted a QRadar collector on our website that supersedes this. Anthony Flaviani Solution Engineering Management Americas Product Specialists Symantec Enterprise Division (SED) | Broadcom Software mobile: 832.298.6016 4003 N Rondelet Dr | Spring, TX 77386 @.*** | broadcom.com

Closing this pull request due to the comment above about a superseding workflow being available from Symantec directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symantec Endpoint Security - ICDM Connector
4 participants