Skip to content

Commit cfbc6e7

Browse files
authored
feat(theme): contrast changes for light and dark themes (#361)
1 parent dc9bdcb commit cfbc6e7

File tree

5 files changed

+37
-29
lines changed

5 files changed

+37
-29
lines changed

README.md

+8-7
Original file line numberDiff line numberDiff line change
@@ -128,16 +128,17 @@ This featureswas added to version 2.4.0. See more about this in [#283](https://g
128128

129129
| Environment variable | light theme value | dark theme value |
130130
| --- | --- | --- |
131-
| `THEME_PRIMARY_TEXT` | `#25313b` | `#8A9EBA` |
132-
| `THEME_NEUTRAL_TEXT` | `#777777` | `#36527A` |
131+
| `THEME_PRIMARY_TEXT` | `#25313b` | `#98a8bd` |
132+
| `THEME_NEUTRAL_TEXT` | `#777777` | `#6d7fab` |
133133
| `THEME_BACKGROUND` | `#ffffff` | `#22272e` |
134-
| `THEME_HOVER_BACKGROUND` | `#eeeeee` | `#30404D` |
135-
| `THEME_ACCENT_TEXT` | `#6680a1` | `#5684FF` |
134+
| `THEME_HOVER_BACKGROUND` | `#eeeeee` | `#343a4b` |
135+
| `THEME_ACCENT_TEXT` | `#5f7796` | `#5c88ff` |
136136
| `THEME_HEADER_TEXT` | `#ffffff` | `#ffffff` |
137-
| `THEME_HEADER_BACKGROUND` | `#25313b` | `#333A45` |
137+
| `THEME_HEADER_ACCENT_TEXT` | `#7b9ac2` | `#7ea1ff` |
138+
| `THEME_HEADER_BACKGROUND` | `#25313b` | `#333a45` |
138139
| `THEME_FOOTER_TEXT` | `#ffffff` | `#ffffff` |
139-
| `THEME_FOOTER_NEUTRAL_TEXT` | `#999999` | `#999999` |
140-
| `THEME_FOOTER_BACKGROUND` | `#555555` | `#555555` |
140+
| `THEME_FOOTER_NEUTRAL_TEXT` | `#adbacd` | `#98afcf` |
141+
| `THEME_FOOTER_BACKGROUND` | `#344251` | `#344251` |
141142

142143
## Recommended Docker Registry Usage
143144

src/components/search-bar.riot

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<material-input
33
label="Search in page"
44
text-color="var(--header-text)"
5-
label-color="var(--neutral-text)"
6-
color="var(--accent-text)"
5+
label-color="var(--header-accent-text)"
6+
color="var(--header-accent-text)"
77
></material-input>
88
<script>
99
import { router } from '@riotjs/route';

src/components/tag-history/tag-history.riot

+3
Original file line numberDiff line numberDiff line change
@@ -287,5 +287,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
287287
flex-direction: row;
288288
align-items: center;
289289
}
290+
h2 .material-icons {
291+
margin-left: .25em;
292+
}
290293
</style>
291294
</tag-history>

src/index.html

+5-3
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,11 @@
5858
theme-background="${THEME_BACKGROUND}"
5959
theme-hover-background="${THEME_HOVER_BACKGROUND}"
6060
theme-accent-text="${THEME_ACCENT_TEXT}"
61+
theme-header-accent-text="${THEME_HEADER_ACCENT_TEXT}"
6162
theme-header-text="${THEME_HEADER_TEXT}"
6263
theme-header-background="${THEME_HEADER_BACKGROUND}"
6364
theme-footer-text="${THEME_FOOTER_TEXT}"
64-
theme-footer-neutra-text="${THEME_FOOTER_NEUTRAL_TEXT}"
65+
theme-footer-neutral-text="${THEME_FOOTER_NEUTRAL_TEXT}"
6566
theme-footer-background="${THEME_FOOTER_BACKGROUND}"
6667
tags-per-page="${TAGLIST_PAGE_SIZE}"
6768
>
@@ -70,7 +71,7 @@
7071
<!-- build:keep developement -->
7172
<docker-registry-ui
7273
registry-url=""
73-
name="Developement Registry"
74+
name="Development Registry"
7475
pull-url=""
7576
show-content-digest="true"
7677
is-image-remove-activated="true"
@@ -90,10 +91,11 @@
9091
theme-background=""
9192
theme-hover-background=""
9293
theme-accent-text=""
94+
theme-header-accent-text=""
9395
theme-header-text=""
9496
theme-header-background=""
9597
theme-footer-text=""
96-
theme-footer-neutra-text=""
98+
theme-footer-neutral-text=""
9799
theme-footer-background=""
98100
tags-per-page=""
99101
>

src/scripts/theme.js

+19-17
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,28 @@
11
const LIGHT_THEME = {
22
'primary-text': '#25313b',
3-
'neutral-text': '#777',
4-
'background': '#fff',
5-
'hover-background': '#eee',
6-
'accent-text': '#6680a1',
7-
'header-text': '#fff',
3+
'neutral-text': '#777777',
4+
'background': '#ffffff',
5+
'hover-background': '#eeeeee',
6+
'accent-text': '#5f7796',
7+
'header-text': '#ffffff',
8+
'header-accent-text': '#7b9ac2',
89
'header-background': '#25313b',
9-
'footer-text': '#fff',
10-
'footer-neutral-text': '#999',
11-
'footer-background': '#555',
10+
'footer-text': '#ffffff',
11+
'footer-neutral-text': '#adbacd',
12+
'footer-background': '#344251',
1213
};
1314
const DARK_THEME = {
14-
'primary-text': '#8A9EBA',
15-
'neutral-text': '#36527A',
15+
'primary-text': '#98a8bd',
16+
'neutral-text': '#6d7fab',
1617
'background': '#22272e',
17-
'hover-background': '#30404D',
18-
'accent-text': '#5684FF',
19-
'header-text': '#fff',
20-
'header-background': '#333A45',
21-
'footer-text': '#fff',
22-
'footer-neutral-text': '#999',
23-
'footer-background': '#555',
18+
'hover-background': '#343a4b',
19+
'accent-text': '#5c88ff',
20+
'header-text': '#ffffff',
21+
'header-accent-text': '#7ea1ff',
22+
'header-background': '#333a45',
23+
'footer-text': '#ffffff',
24+
'footer-neutral-text': '#98afcf',
25+
'footer-background': '#344251',
2426
};
2527

2628
const LOCAL_STORAGE_THEME = 'registryUiTheme';

0 commit comments

Comments
 (0)