refactor: extract vm update function

Author: romain-neil

model/VirtualMachine.go

@@ -32,23 +32,50 @@ func NewVM(n *Netbox, msg Message) *VirtualMachine {
 	return vm
 }
 
-func (vm *VirtualMachine) Create(msg Message) models.WritableVirtualMachineWithConfigContext {
-	var (
-		status        = "planned"
-		cluster int64 = 1
-	)
+func (vm *VirtualMachine) Get() models.WritableVirtualMachineWithConfigContext {
+	// todo: implement netbox func
+	return models.WritableVirtualMachineWithConfigContext{
+		Cluster: &vm.Cluster.ID,
+		Name:    &vm.Name,
+		Status:  vm.Status,
 
+		CustomFields: map[string]interface{}{
+			"kc_serial_": vm.Serial,
+		},
+	}
+}
+
+func (vm *VirtualMachine) Create(msg Message) (*virtualization.VirtualizationVirtualMachinesCreateCreated, error) {
 	conf := models.WritableVirtualMachineWithConfigContext{
-		Cluster: &cluster,
-		Name:    &msg.Hostname,
-		Status:  status,
+		Cluster: &vm.Cluster.ID,
+		Name:    &vm.Name,
+		Status:  vm.Status,
 
 		CustomFields: map[string]interface{}{
 			"kc_serial_": msg.GetSerial(),
 		},
 	}
 
-	return conf
+	params := virtualization.NewVirtualizationVirtualMachinesCreateParams().WithData(&conf)
+	return vm.n.Client.Virtualization.VirtualizationVirtualMachinesCreate(params, nil)
+}
+
+// Update vm infos to netbox
+func (vm *VirtualMachine) Update() error {
+	data := vm.Get()
+
+	updateParams := &virtualization.VirtualizationVirtualMachinesPartialUpdateParams{
+		Data: &data,
+		ID:   vm.NetboxId,
+	}
+
+	_, err := vm.n.Client.Virtualization.
+		VirtualizationVirtualMachinesPartialUpdate(updateParams.WithTimeout(vm.n.GetDefaultTimeout()), nil)
+	if err != nil {
+		return fmt.Errorf("error updating virtual machine interface: %w", err)
+	}
+
+	return nil
 }
 
 func (vm *VirtualMachine) GetInterfaces(n *Netbox, name string) (*virtualization.VirtualizationInterfacesListOK, error) {

model/netbox.go

@@ -176,11 +176,11 @@ func (n *Netbox) UpdateVM(id int64, msg Message) error {
 	vm := NewVM(n, msg)
 	vm.NetboxId = id
 
-	vmConf := vm.Create(msg)
+	_, err := vm.Create(msg)
 
-	updateParams := &virtualization.VirtualizationVirtualMachinesPartialUpdateParams{
-		Data: &vmConf,
-		ID:   id,
+	err = vm.Update()
+	if err != nil {
+		return err
 	}
 
 	//Update management IP
@@ -201,32 +201,12 @@ func (n *Netbox) UpdateVM(id int64, msg Message) error {
 	)
 	if *ifCount < 1 {
 		//No virtual interface, create one
-		var (
-			mgmtInterfaceName = "mgmt"
-		)
-
-		ifParam := models.WritableVMInterface{
-			Name:    &mgmtInterfaceName,
-			Enabled: true,
-
-			TaggedVlans: []int64{},
 
-			VirtualMachine: &id,
-		}
-		paramInterface := virtualization.
-			NewVirtualizationInterfacesCreateParams().
-			WithData(&ifParam).WithTimeout(n.GetDefaultTimeout())
-		_, err := n.Client.Virtualization.VirtualizationInterfacesCreate(paramInterface, nil)
+		_, err := vm.CreateInterface(n, "mgmt")
 		if err != nil {
 			return fmt.Errorf("error creating virtual machine interface: %w", err)
 		}
 
-		_, err = n.Client.Virtualization.
-			VirtualizationVirtualMachinesPartialUpdate(updateParams.WithTimeout(n.GetDefaultTimeout()), nil)
-		if err != nil {
-			return fmt.Errorf("error updating virtual machine interface: %w", err)
-		}
-
 		util.Info("Updated VM #" + strconv.FormatInt(id, 10) + " management interface with IP " + msg.IpAddress)
 		return nil
 	}