fix logic

romain-neil · romain-neil · commit 5f68f2b4a023 · 2024-09-05T21:59:29.000+02:00
diff --git a/model/netbox.go b/model/netbox.go
@@ -240,7 +240,6 @@ func (n *Netbox) VmExists(hostname string, serial string) (bool, int64, error) {
 
 		var cf = v.CustomFields.(map[string]interface{})
 		var serial = ""
-		_ = serial
 
 		for k, v := range cf {
 			switch c := v.(type) {
@@ -251,7 +250,7 @@ func (n *Netbox) VmExists(hostname string, serial string) (bool, int64, error) {
 			}
 		}
 
-		if serial == serial {
+		if serial != "" {
 			return true, v.ID, nil
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,6 @@ func (n *Netbox) VmExists(hostname string, serial string) (bool, int64, error) {`
`240`	`240`
`241`	`241`	`var cf = v.CustomFields.(map[string]interface{})`
`242`	`242`	`var serial = ""`
`243`		`- _ = serial`
`244`	`243`
`245`	`244`	`for k, v := range cf {`
`246`	`245`	`switch c := v.(type) {`
`@@ -251,7 +250,7 @@ func (n *Netbox) VmExists(hostname string, serial string) (bool, int64, error) {`
`251`	`250`	`}`
`252`	`251`	`}`
`253`	`252`
`254`		`- if serial == serial {`
	`253`	`+ if serial != "" {`
`255`	`254`	`return true, v.ID, nil`
`256`	`255`	`}`
`257`	`256`	`}`