Skip to content

Commit 741b815

Browse files
committed
refactor: add timeout
1 parent 242f674 commit 741b815

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

model/netbox.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,11 @@ func (n *Netbox) CreateVM(msg Message) error {
184184

185185
vmID := strconv.FormatInt(vmInterfaceResult.Payload.VirtualMachine.ID, 10)
186186

187-
nestedVmParams := virtualization.VirtualizationInterfacesListParams{
187+
nestedVmParams := &virtualization.VirtualizationInterfacesListParams{
188188
Name: &mgmtInterfaceName,
189189
VirtualMachineID: &vmID,
190190
}
191-
nestedVmInterfaces, err := n.Client.Virtualization.VirtualizationInterfacesList(&nestedVmParams, nil)
191+
nestedVmInterfaces, err := n.Client.Virtualization.VirtualizationInterfacesList(nestedVmParams.WithTimeout(time.Duration(30)*time.Second), nil)
192192
if err != nil {
193193
return fmt.Errorf("error listing virtual machine interfaces: %w", err)
194194
}
@@ -228,11 +228,11 @@ func (n *Netbox) UpdateVM(id int64, msg Message) error {
228228
mgmtIfName = "mgmt"
229229
)
230230

231-
ipIfParam := virtualization.VirtualizationInterfacesListParams{
231+
ipIfParam := &virtualization.VirtualizationInterfacesListParams{
232232
VirtualMachineID: &vmId,
233233
Name: &mgmtIfName,
234234
}
235-
interfaces, err := n.Client.Virtualization.VirtualizationInterfacesList(&ipIfParam, nil)
235+
interfaces, err := n.Client.Virtualization.VirtualizationInterfacesList(ipIfParam.WithTimeout(time.Duration(30)*time.Second), nil)
236236
if err != nil {
237237
return fmt.Errorf("error listing virtual machine interfaces: %w", err)
238238
}
@@ -256,7 +256,7 @@ func (n *Netbox) UpdateVM(id int64, msg Message) error {
256256

257257
VirtualMachine: &id,
258258
}
259-
paramInterface := virtualization.NewVirtualizationInterfacesCreateParams().WithData(&ifParam)
259+
paramInterface := virtualization.NewVirtualizationInterfacesCreateParams().WithData(&ifParam).WithTimeout(time.Duration(30) * time.Second)
260260
_, err := n.Client.Virtualization.VirtualizationInterfacesCreate(paramInterface, nil)
261261
if err != nil {
262262
return fmt.Errorf("error creating virtual machine interface: %w", err)
@@ -309,7 +309,7 @@ func (n *Netbox) UpdateVM(id int64, msg Message) error {
309309
AssignedObjectID: nil,
310310
}
311311

312-
paramUnlinkOldIp := ipam.NewIpamIPAddressesPartialUpdateParams().WithID(ip.ID).WithData(&oldIpUpdatePrams)
312+
paramUnlinkOldIp := ipam.NewIpamIPAddressesPartialUpdateParams().WithID(ip.ID).WithData(&oldIpUpdatePrams).WithTimeout(time.Duration(30) * time.Second)
313313
_, err = n.Client.Ipam.IpamIPAddressesPartialUpdate(paramUnlinkOldIp, nil)
314314
if err != nil {
315315
return fmt.Errorf("error updating management ip addresses of VM #"+vmId+": %w", err)

0 commit comments

Comments
 (0)