Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] ZHOME_BEFORE_LEVELING appears in only one line #27703

Open
1 task done
mennucc opened this issue Feb 22, 2025 · 2 comments
Open
1 task done

[FR] ZHOME_BEFORE_LEVELING appears in only one line #27703

mennucc opened this issue Feb 22, 2025 · 2 comments

Comments

@mennucc
Copy link

mennucc commented Feb 22, 2025

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

dear all,

I was browsing in the source code (I have some problems with UBL ABL), branch origin/bugfix-2.1.x ; I noted that the define ZHOME_BEFORE_LEVELING appears in only one line in the whole source code , namely

./Marlin/src/feature/bedlevel/ubl/ubl_G29.cpp:323: #if ALL(DWIN_LCD_PROUI, ZHOME_BEFORE_LEVELING)

this is weird

Bug Timeline

No response

Expected behavior

A define should appear also somewhere else, e.g. in configuration files, with some documentation

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

origin/bugfix-2.1.x

Printer model

(not relevant)

Electronics

(not relevant)

LCD/Controller

(not relevant)

Other add-ons

(not relevant)

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

(not relevant)

@ellensp
Copy link
Contributor

ellensp commented Feb 22, 2025

added in #26003

is DWIN ProUI specific defines

@bmourit
Copy link

bmourit commented Feb 26, 2025

Scratch that. I see what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants