Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: For the Revoke permissions the "Set Approval for All" screen is shown, the transaction is also labeled as "Set Approval for All" within the Activity list. #13789

Open
sleepytanya opened this issue Mar 1, 2025 · 0 comments
Labels
regression-prod-7.38.0 Regression bug that was found in production in release 7.38.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Mar 1, 2025

Describe the bug

When revoking permissions for ERC 721 and ERC 1155, users are presented with the "Set Approval for All" screen, and subsequently, the transaction is also labeled as "Set Approval for All" within the Activity list.

Expected behavior

Accurate transaction descriptions and user interface prompts.

Screenshots/Recordings

revoke.mov

Steps to reproduce

  1. Connect to test dapp
  2. Deploy a contract, mint an NFT
  3. Grant / revoke permission

Error messages or log output

Detection stage

In production (default)

Version

7.38.0

Build type

None

Device

iPhone 15

Operating system

iOS

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added regression-prod-7.38 Regression bug that was found in production in release 7.38 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team type-bug Something isn't working labels Mar 1, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Mar 1, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Mar 1, 2025
@metamaskbot metamaskbot added regression-prod-7.38.0 Regression bug that was found in production in release 7.38.0 and removed regression-prod-7.38 Regression bug that was found in production in release 7.38 labels Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-7.38.0 Regression bug that was found in production in release 7.38.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants