feat(vpcgw): add support for vpc public gateway ip (scaleway#863)

Author: remyleone

scaleway/provider.go

@@ -94,10 +94,7 @@ func Provider(config *ProviderConfig) plugin.ProviderFunc {
 				"scaleway_rdb_user":                      resourceScalewayRdbUser(),
 				"scaleway_object_bucket":                 resourceScalewayObjectBucket(),
 				"scaleway_vpc_public_gateway":            resourceScalewayVPCPublicGateway(),
-				"scaleway_vpc_gateway_network":           resourceScalewayVPCGatewayNetwork(),
-				"scaleway_vpc_public_gateway_dhcp":       resourceScalewayVPCPublicGatewayDHCP(),
 				"scaleway_vpc_public_gateway_ip":         resourceScalewayVPCPublicGatewayIP(),
-				"scaleway_vpc_public_gateway_pat_rule":   resourceScalewayVPCPublicGatewayPATRule(),
 				"scaleway_vpc_private_network":           resourceScalewayVPCPrivateNetwork(),
 			},
 
@@ -122,7 +119,6 @@ func Provider(config *ProviderConfig) plugin.ProviderFunc {
 				"scaleway_registry_namespace":      dataSourceScalewayRegistryNamespace(),
 				"scaleway_registry_image":          dataSourceScalewayRegistryImage(),
 				"scaleway_vpc_public_gateway":      dataSourceScalewayVPCPublicGateway(),
-				"scaleway_vpc_public_gateway_dhcp": dataSourceScalewayVPCPublicGatewayDHCP(),
 				"scaleway_vpc_public_gateway_ip":   dataSourceScalewayVPCPublicGatewayIP(),
 				"scaleway_vpc_private_network":     dataSourceScalewayVPCPrivateNetwork(),
 			},

scaleway/resource_vpc_public_gateway_ip.go

@@ -34,16 +34,15 @@ func resourceScalewayVPCPublicGatewayIP() *schema.Resource {
 					Type: schema.TypeString,
 				},
 			},
-			"project_id": projectIDSchema(),
-			"zone":       zoneSchema(),
-			// Computed elements
-			"organization_id": organizationIDSchema(),
 			"reverse": {
 				Type:        schema.TypeString,
 				Optional:    true,
-				Computed:    true,
 				Description: "reverse domain name for the IP address",
 			},
+			"project_id": projectIDSchema(),
+			"zone":       zoneSchema(),
+			// Computed elements
+			"organization_id": organizationIDSchema(),
 			"created_at": {
 				Type:        schema.TypeString,
 				Computed:    true,
@@ -75,20 +74,6 @@ func resourceScalewayVPCPublicGatewayIPCreate(ctx context.Context, d *schema.Res
 		return diag.FromErr(err)
 	}
 
-	reverse := d.Get("reverse")
-	if len(reverse.(string)) > 0 {
-		updateRequest := &vpcgw.UpdateIPRequest{
-			IPID:    res.ID,
-			Zone:    zone,
-			Tags:    scw.StringsPtr(expandStrings(d.Get("tags"))),
-			Reverse: expandStringPtr(reverse.(string)),
-		}
-		_, err = vpcgwAPI.UpdateIP(updateRequest, scw.WithContext(ctx))
-		if err != nil {
-			return diag.FromErr(err)
-		}
-	}
-
 	d.SetId(newZonedIDString(zone, res.ID))
 
 	return resourceScalewayVPCPublicGatewayIPRead(ctx, d, meta)
@@ -113,7 +98,6 @@ func resourceScalewayVPCPublicGatewayIPRead(ctx context.Context, d *schema.Resou
 	}
 
 	_ = d.Set("organization_id", ip.OrganizationID)
-	_ = d.Set("address", ip.Address.String())
 	_ = d.Set("project_id", ip.ProjectID)
 	_ = d.Set("created_at", ip.CreatedAt.Format(time.RFC3339))
 	_ = d.Set("updated_at", ip.UpdatedAt.Format(time.RFC3339))

scaleway/resource_vpc_public_gateway_ip_test.go

@@ -58,10 +58,6 @@ func TestAccScalewayVPCPublicGatewayIP_Basic(t *testing.T) {
 				`,
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckScalewayVPCPublicGatewayIPExists(tt, "scaleway_vpc_public_gateway_ip.main"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "reverse"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "address"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "created_at"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "updated_at"),
 				),
 			},
 			{
@@ -76,25 +72,6 @@ func TestAccScalewayVPCPublicGatewayIP_Basic(t *testing.T) {
 					resource.TestCheckResourceAttr("scaleway_vpc_public_gateway_ip.main", "tags.0", "tag0"),
 					resource.TestCheckResourceAttr("scaleway_vpc_public_gateway_ip.main", "tags.1", "tag1"),
 					resource.TestCheckResourceAttr("scaleway_vpc_public_gateway_ip.main", "reverse", "example.com"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "address"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "created_at"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "updated_at"),
-				),
-			},
-			{
-				Config: `
-					resource scaleway_vpc_public_gateway_ip main {
-						tags = ["tag2", "tag3"]
-					}
-				`,
-				Check: resource.ComposeTestCheckFunc(
-					testAccCheckScalewayVPCPublicGatewayIPExists(tt, "scaleway_vpc_public_gateway_ip.main"),
-					resource.TestCheckResourceAttr("scaleway_vpc_public_gateway_ip.main", "tags.0", "tag2"),
-					resource.TestCheckResourceAttr("scaleway_vpc_public_gateway_ip.main", "tags.1", "tag3"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "reverse"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "address"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "created_at"),
-					resource.TestCheckResourceAttrSet("scaleway_vpc_public_gateway_ip.main", "updated_at"),
 				),
 			},
 		},