Add support for authenticated iframe (with JWT) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image renderer from Grafana is very slow and cpu heavy. Iframe is not an option for most cases because it needs anonymous access to Grafana. This commit adds JWT support to secure the Grafana access when using iframe. When a graph is loaded in Icinga web interface, the signed JWT token is sent to Grafana in the request, if JWT is validated graph is displayed, if anything goes wrong with the token validation, Grafana will refuse the access. The library Firebase PHP-JWT is used to create the token. For now, the library is included in the vendor directory. The JWT token uses RSA keys, these keys are generated automatically in /etc when the user saves the configuration with jwt enabled.
jbonor
force-pushed
the
feature/iframe-jwtauth
branch
from
9d998b7 to
88d943c
Compare
Signed-off-by: Jorge Boncompte <[email protected]>
jbonor
force-pushed
the
feature/iframe-jwtauth
branch
from
88d943c to
35ccd8c
Compare
|
Hi, thanks for the PR and for putting in the work to cleanup the code. I'll give it some proper testing and then some feedback. Cheers |
martialblog
reviewed
Mar 3, 2025
martialblog
force-pushed
the
release/v3.1.0
branch
from
35ccd8c to
d9b0633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for iframe authentication with JWT based on the work of Mikesch-mp/icingaweb2-module-grafana/pull/326
Removed vendor dependencies with a simple function to create the tokens and general cleanup
Closes #49