Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search action no longer runs successfully #389

Closed
Mic92 opened this issue Dec 14, 2021 · 5 comments
Closed

Search action no longer runs successfully #389

Mic92 opened this issue Dec 14, 2021 · 5 comments
Assignees

Comments

@Mic92
Copy link
Member

Mic92 commented Dec 14, 2021

See github action error: https://github.com/NixOS/nixos-search/runs/4521001235?check_suite_focus=true

@Mic92 Mic92 changed the title Search no longer updates Search action no longer runs successfully Dec 14, 2021
@ysndr
Copy link
Member

ysndr commented Dec 14, 2021

Thanks, I am on it

@ysndr ysndr self-assigned this Dec 14, 2021
@ysndr
Copy link
Member

ysndr commented Dec 15, 2021

It is because the maintainer of gotypist did not add themselves to the maintainers.nix file but instead wrote is name as a string, which is unexpected to nix-flakes.
A fix for this has been submitted and merged

@pb-
Copy link

pb- commented Dec 15, 2021

@ysndr Sorry about that, I didn't realize that a string was unacceptable 🙈 . Thank you for fixing it.

It looks like the action still doesn't succeed, though.

@ysndr
Copy link
Member

ysndr commented Dec 15, 2021

Thats alright, its been overlooked during review everything is alright.
The action wont succeed until there is an updated nixos-unstable with that change included, lets see when that is going to land.

@ysndr
Copy link
Member

ysndr commented Dec 18, 2021

Worked around in #393

@ysndr ysndr closed this as completed Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants