Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hygiene] Support CIDR and Partial Domains #2263

Closed
annoyingapt opened this issue Jun 28, 2024 · 2 comments
Closed

[Hygiene] Support CIDR and Partial Domains #2263

annoyingapt opened this issue Jun 28, 2024 · 2 comments
Labels
feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team

Comments

@annoyingapt
Copy link
Contributor

Use case

Currently the Hygiene connector won't match an IP with a CIDR address in the list. It also won't match a partial domain in a list either.

CIDR example
1.255.30.0/24 in vpn-ipv4 list
Tested with 1.255.30.45 -> Hygiene failed to match
Tested with 1.255.30.0/24 -> works

Domain example
.02bancorp.com in bank website list
Tested with www.02bancorp.com -> Hygiene failed to match

Additional Information

image

Would you be willing to submit a PR?

Possibly... If you had some guidance on how you would want it to work.

@annoyingapt annoyingapt added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team labels Jun 28, 2024
@annoyingapt annoyingapt changed the title [Hygiene] Update connector [Hygiene] Support CIDR and Partial Domains Jun 28, 2024
@baptiste-fourmont
Copy link
Contributor

Hello,

Did you have activate the slow search mode in the connector?

@annoyingapt
Copy link
Contributor Author

I've ended up using the pymispwarninglists library instead of using the Hygiene connector. I can confirm that slow search is needed to match with cidr objects etc. I can't confirm that the hygiene connector is working as I don't use it, but as my issue is resolved, I'm closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team
Projects
None yet
Development

No branches or pull requests

2 participants