Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Comlaude] improvements #3054

Closed
yassine-ouaamou opened this issue Dec 2, 2024 · 0 comments · Fixed by #3459
Closed

[Comlaude] improvements #3054

yassine-ouaamou opened this issue Dec 2, 2024 · 0 comments · Fixed by #3459
Assignees
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@yassine-ouaamou
Copy link
Member

I am creating this issue to include the following improvements on the connector:

  • Add the “_deserialize_json_string” function to convert the JSON-formatted text string into a python object, which eliminates json errors when executing on OpenCTI.
  • Add “_validate_required_fields” function to check that all required data (mandatory fields) are present and not empty, which also prevents errors in OpenCTI executions
  • Add the “_ping_connector” function, which pings the connector every 5 minutes to keep it active (by modifying the “run” function).
    Status tracking with “last_run” variable in format “{”last_run“: ‘2024-11-18T15:13:36Z’}”.
@yassine-ouaamou yassine-ouaamou added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team labels Dec 2, 2024
@yassine-ouaamou yassine-ouaamou removed the needs triage use to identify issue needing triage from Filigran Product team label Dec 2, 2024
@helene-nguyen helene-nguyen linked a pull request Feb 24, 2025 that will close this issue
4 tasks
@helene-nguyen helene-nguyen added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 24, 2025
@helene-nguyen helene-nguyen self-assigned this Feb 24, 2025
@helene-nguyen helene-nguyen added this to the Release 6.5.4 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants