[backend] Adapt dynamic filtering for special instance control (#4538)

Author: richard-julien

opencti-platform/opencti-graphql/src/utils/access.ts

@@ -440,8 +440,8 @@ export const userFilterStoreElements = async (context: AuthContext, user: AuthUs
         // If element is shared, user must have a matching sharing organization
         return elementOrganizations.some((r) => userOrganizations.includes(r));
       }
-      // If no platform organization is set, user can access empty sharing and dedicated sharing
-      return elementOrganizations.length === 0 || elementOrganizations.some((r) => userOrganizations.includes(r));
+      // If no platform organization is set, user can
+      return true;
     });
   };
   return telemetry(context, user, 'FILTERING store filter', {
@@ -491,8 +491,8 @@ export const isUserCanAccessStixElement = async (context: AuthContext, user: Aut
     // If element is shared, user must have a matching sharing organization
     return elementOrganizations.some((r) => userOrganizations.includes(r));
   }
-  // If no platform organization is set, user can access empty sharing and dedicated sharing
-  return elementOrganizations.length === 0 || elementOrganizations.some((r) => userOrganizations.includes(r));
+  // If no platform organization is set, user can access
+  return true;
 };
 
 // region member access

opencti-platform/opencti-graphql/tests/02-integration/04-manager/notificationManager-test.js

@@ -1392,7 +1392,7 @@ describe('Notification manager behaviors test', async () => {
 
     // O is a green organization, trigger on O and another organization
     result = await buildTargetEvents(context, users, streamEventShareMalwareWithGreenOrganization, triggerOrganizationsAllEvents, true);
-    expect(result.length).toEqual(1);
+    expect(result.length).toEqual(2);
     expect(result[0].type).toEqual(EVENT_TYPE_UPDATE);
     expect(result[0].message).toEqual('[identity] greenOrganization_name added in [malware] malware_name');