From 253bb091cc96f9fe6c9a092caebc90c4ec808960 Mon Sep 17 00:00:00 2001
From: marie flores <marie.flores@filigran.io>
Date: Tue, 25 Feb 2025 14:33:38 +0100
Subject: [PATCH 1/2] [frontend] Mandatory file for Artifact creation

---
 .../StixCyberObservableCreation.jsx                   | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/opencti-platform/opencti-front/src/private/components/observations/stix_cyber_observables/StixCyberObservableCreation.jsx b/opencti-platform/opencti-front/src/private/components/observations/stix_cyber_observables/StixCyberObservableCreation.jsx
index 366a9445dab0..111c83e87bfe 100644
--- a/opencti-platform/opencti-front/src/private/components/observations/stix_cyber_observables/StixCyberObservableCreation.jsx
+++ b/opencti-platform/opencti-front/src/private/components/observations/stix_cyber_observables/StixCyberObservableCreation.jsx
@@ -574,6 +574,11 @@ const StixCyberObservableCreation = ({
                       is: (a, b, c, d) => !a && !b && !c && !d,
                       then: () => Yup.string().required(t_i18n('MD5, SHA-1, SHA-256, SHA-512, or name is required')),
                     }),
+                  file: Yup.mixed().when([], {
+                    is: () => status.type === 'Artifact',
+                    then: () => Yup.mixed().required(t_i18n('This field is required for an Artifact')),
+                    otherwise: () => Yup.mixed().nullable(),
+                  }),
                 };
 
                 requiredOneOfFields = [
@@ -628,6 +633,7 @@ const StixCyberObservableCreation = ({
                   setFieldValue,
                   values,
                   resetForm,
+                  errors,
                 }) => (
                   <>
                     {bulkConf && (
@@ -848,10 +854,9 @@ const StixCyberObservableCreation = ({
                         setFieldValue={setFieldValue}
                         values={values.externalReferences}
                       />
-                      <Field
-                        component={CustomFileUploader}
-                        name="file"
+                      <CustomFileUploader
                         setFieldValue={setFieldValue}
+                        formikErrors={errors}
                         disabled={bulkConf && bulkSelectedKey && splitMultilines(values[bulkSelectedKey]).length > 1}
                         noFileSelectedLabel={bulkConf && bulkSelectedKey && splitMultilines(values[bulkSelectedKey]).length > 1
                           ? t_i18n('File upload not allowed in bulk creation')

From 08b492b62e864665496fe4c82386554fc8ed2ceb Mon Sep 17 00:00:00 2001
From: marie flores <marie.flores@filigran.io>
Date: Tue, 25 Feb 2025 14:58:54 +0100
Subject: [PATCH 2/2] [frontend] fix translation

---
 .../stix_cyber_observables/StixCyberObservableCreation.jsx      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/opencti-platform/opencti-front/src/private/components/observations/stix_cyber_observables/StixCyberObservableCreation.jsx b/opencti-platform/opencti-front/src/private/components/observations/stix_cyber_observables/StixCyberObservableCreation.jsx
index 111c83e87bfe..d90c90a387da 100644
--- a/opencti-platform/opencti-front/src/private/components/observations/stix_cyber_observables/StixCyberObservableCreation.jsx
+++ b/opencti-platform/opencti-front/src/private/components/observations/stix_cyber_observables/StixCyberObservableCreation.jsx
@@ -576,7 +576,7 @@ const StixCyberObservableCreation = ({
                     }),
                   file: Yup.mixed().when([], {
                     is: () => status.type === 'Artifact',
-                    then: () => Yup.mixed().required(t_i18n('This field is required for an Artifact')),
+                    then: () => Yup.mixed().required(t_i18n('This field is required')),
                     otherwise: () => Yup.mixed().nullable(),
                   }),
                 };