fixup! core: refacto combo box

Author: clarani

ui-core/src/components/inputs/ComboBox/useDefaultComboBox.ts

@@ -1,4 +1,4 @@
-import { useEffect, useState } from 'react';
+import { useMemo, useState } from 'react';
 
 const normalizeString = (str: string) => str.normalize('NFD').replace(/[\u0300-\u036f]/g, '');
 
@@ -37,21 +37,20 @@ const defaultFilterSuggestions = <T>(
 };
 
 const useDefaultComboBox = <T>(suggestions: T[], getSuggestionLabel: (suggestion: T) => string) => {
-  const [filteredSuggestions, setFilteredSuggestions] = useState<T[]>(suggestions);
   const [query, setQuery] = useState('');
 
+  const filteredSuggestions = useMemo(
+    () => defaultFilterSuggestions(getSuggestionLabel, suggestions, query),
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [suggestions, query]
+  );
+
   const onChange = (e: React.ChangeEvent<HTMLInputElement>) => {
     setQuery(e.target.value);
   };
 
-  useEffect(() => {
-    const newSuggestions = defaultFilterSuggestions(getSuggestionLabel, suggestions, query);
-    setFilteredSuggestions(newSuggestions);
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [suggestions, query]);
-
   const resetSuggestions = () => {
-    setFilteredSuggestions(suggestions);
+    setQuery('');
   };
 
   return { suggestions: filteredSuggestions, onChange, resetSuggestions };