Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waypoint menu position not dynamic #667

Closed
3 tasks
SharglutDev opened this issue Oct 24, 2024 · 1 comment · Fixed by #668
Closed
3 tasks

Waypoint menu position not dynamic #667

SharglutDev opened this issue Oct 24, 2024 · 1 comment · Fixed by #668

Comments

@SharglutDev
Copy link
Contributor

SharglutDev commented Oct 24, 2024

What happened?

When the waypoint menu is open, if the manchette can be scrolled (long list of waypoints), the menu stays at the same origin position, it's not dynamic.

What did you expect to happen?

  • The manchette becomes not scrollable when the menu is displayed
  • We scroll in the page if we try to scroll when the menu is displayed, not in the manchette
  • Zoom and mode buttons are disabled when menu is displayed

How can we reproduce it (as minimally and precisely as possible)?

  1. In sampleData.ts, add pathProperties data from a long path so the manchette can be scrolled
  2. Click on a waypoint to open its menu
  3. Scroll and see the menu not moving

On which environments the bug occurs?

Deployed Storybook

On which browser the bug occurs?

Firefox

@SharglutDev
Copy link
Contributor Author

After discussion with @thibautsailly, it has been decided to totally block the scroll in the manchette (and only in the manchette) as long as the menu is displayed. If we still try to scroll, the whole page will scroll. (AC updated accordingly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant