ui-spacetimechart: picking layer downscaling #938
+98
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Feb 28, 2025
emersion
reviewed
Feb 28, 2025
emersion
reviewed
Feb 28, 2025
This commit fixes #915, and also improves picking performances, by downscaling the picking layer. Details: - Cleans unused and poorly named "number" argument from drawAliasedLine - Adds new get getPickingScalingRatio helper, that returns the picking downscaling ratio depending on the current devicePixelRatio value - Fixes picking layers resize handling - Adds a new optional "scalingRatio" argument to each canvas aliased drawing function - Adds new scalingRatio argument to PickingDrawingFunction, and updates useCanvas accordingly - Gives the scaling ratio from PickingDrawingFunction to aliased functions in every places where usePicking is called Signed-off-by: Alexis Jacomy <[email protected]>
clarani
reviewed
Mar 7, 2025
Comment on lines
+16
to
+24
| // When devicePixelRatio is over 1 (like for Retina displays), we downscale based on the "HTML | ||
| // pixels": | ||
| if (dpr > 1) return PICKING_DOWNSCALING_RATIO; | ||
|
|
||
| // When devicePixelRatio is under 1 (like when the user zooms out for instance), we downscale | ||
| // based on the actual "screen pixels" (to avoid having a too large scene to fill): | ||
| if (dpr < 1) return PICKING_DOWNSCALING_RATIO * dpr; | ||
|
|
||
| return PICKING_DOWNSCALING_RATIO; |
There was a problem hiding this comment.
Suggested change
| // When devicePixelRatio is over 1 (like for Retina displays), we downscale based on the "HTML | |
| // pixels": | |
| if (dpr > 1) return PICKING_DOWNSCALING_RATIO; | |
| // When devicePixelRatio is under 1 (like when the user zooms out for instance), we downscale | |
| // based on the actual "screen pixels" (to avoid having a too large scene to fill): | |
| if (dpr < 1) return PICKING_DOWNSCALING_RATIO * dpr; | |
| return PICKING_DOWNSCALING_RATIO; | |
| // When devicePixelRatio is over 1 (like for Retina displays), we downscale based on the "HTML | |
| // pixels": | |
| if (dpr >= 1) return PICKING_DOWNSCALING_RATIO; | |
| // When devicePixelRatio is under or equal to 1 (like when the user zooms out for instance), we downscale | |
| // based on the actual "screen pixels" (to avoid having a too large scene to fill): | |
| return PICKING_DOWNSCALING_RATIO * dpr; |
clarani
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #915, and also improves picking performances, by downscaling the picking layer.
Details: