-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui-core: enable the user to type in the date picker #547
Conversation
dbdf90d
to
0e4b6ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work !
Please, could you update tests for handleInputClick
and add tests for handleInputOnChange
?
I noticed a strange behavior with the date validation:
- When I enter a date that is out of the allowed range, the date picker shows the error message correctly.
- If I then type something that is not a date (e.g., "toto"), the date picker stays in error mode, which is expected.
- However, when I enter a valid date afterward, the date picker still shows as invalid, even though it should reset.
Also, when I type a non-date string (e.g., "toto") from the beginning, the input does not show an invalid message.
Thanks for your review, I modified a bit the behaviors:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job !
Signed-off-by: Clara Ni <[email protected]>
0538bc0
to
91f1a45
Compare
closes #526
Some remarks:
Technical remarks:
When the input is invalid:
