Skip to content

Commit 11da135

Browse files
committed
front: integrate ui-core
front: fix forgotten img front: fix notification buttons on map editor
1 parent 95493fe commit 11da135

File tree

14 files changed

+219
-26
lines changed

14 files changed

+219
-26
lines changed

front/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
"@nivo/line": "^0.80.0",
1010
"@nivo/tooltip": "^0.80.0",
1111
"@openapi-contrib/openapi-schema-to-json-schema": "^5.1.0",
12-
"@osrd-project/ui-icons": "^0.0.10",
12+
"@osrd-project/ui-core": "^0.0.21",
13+
"@osrd-project/ui-icons": "^0.0.21",
1314
"@redux-devtools/extension": "^3.3.0",
1415
"@reduxjs/toolkit": "^2.1.0",
1516
"@rjsf/core": "^5.17.0",

front/src/applications/editor/components/LayersModal.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ const LayersModal: FC<LayersModalProps> = ({
150150
disabled={disabled}
151151
/>
152152
{isString(icon) ? (
153-
<img className="mx-2" src={icon} alt="" height="20" />
153+
<img className="layer-modal-img mx-2" src={icon} alt="" />
154154
) : (
155155
<div>{icon}</div>
156156
)}

front/src/applications/operationalStudies/views/ScenarioV1.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ const ScenarioV1 = () => {
264264
<div className="row">
265265
<div className="col-md-6">
266266
<div className="scenario-details-infra-name">
267-
<img src={infraLogo} alt="Infra logo" className="mr-2" />
267+
<img src={infraLogo} alt="Infra logo" className="infra-logo mr-2" />
268268
{infra && <InfraLoadingState infra={infra} />}
269269
<span className="scenario-infra-name">{scenario.infra_name}</span>
270270
<small className="ml-auto text-muted">ID {scenario.infra_id}</small>
@@ -355,7 +355,7 @@ const ScenarioV1 = () => {
355355
</button>
356356
<div className="lead ml-2">{scenario.name}</div>
357357
<div className="d-flex align-items-center ml-auto">
358-
<img src={infraLogo} alt="Infra logo" className="mr-2" height="16" />
358+
<img src={infraLogo} alt="Infra logo" className="infra-logo mr-2" />
359359
{scenario.infra_name}
360360
</div>
361361
<div className="d-flex align-items-center ml-4">

front/src/applications/operationalStudies/views/v2/ScenarioV2.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ const ScenarioV2 = () => {
256256
<div className="row">
257257
<div className="col-md-6">
258258
<div className="scenario-details-infra-name">
259-
<img src={infraLogo} alt="Infra logo" className="mr-2" />
259+
<img src={infraLogo} alt="Infra logo" className="infra-logo mr-2" />
260260
{infra && <InfraLoadingState infra={infra} />}
261261
<span className="scenario-infra-name">{scenario.infra_name}</span>
262262
<small className="ml-auto text-muted">ID {scenario.infra_id}</small>
@@ -347,7 +347,7 @@ const ScenarioV2 = () => {
347347
</button>
348348
<div className="lead ml-2">{scenario.name}</div>
349349
<div className="d-flex align-items-center ml-auto">
350-
<img src={infraLogo} alt="Infra logo" className="mr-2" height="16" />
350+
<img src={infraLogo} alt="Infra logo" className="infra-logo mr-2" />
351351
{scenario.infra_name}
352352
</div>
353353
<div className="d-flex align-items-center ml-4">

front/src/common/Map/Settings/MapSettingsBackgroundSwitches.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const FormatSwitch: FC<{
4646
checked={state}
4747
disabled={disabled}
4848
/>
49-
<img className="ml-2 rounded" src={icon} alt="" height="24" />
49+
<img className="map-format-switch-img ml-2 rounded" src={icon} alt="" />
5050
<span className="ml-2">{t(label)}</span>
5151
</div>
5252
);

front/src/common/Map/Settings/MapSettingsLayers.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export const FormatSwitch: FC<FormatSwitchProps> = ({ name, icon, color, disable
5858
};
5959

6060
export const Icon2SVG: FC<{ file: string; altName?: string }> = ({ file, altName }) => (
61-
<img src={file} alt={altName} height="16" />
61+
<img className="icon-to-svg" src={file} alt={altName} />
6262
);
6363

6464
const MapSettingsLayers: FC<unknown> = () => (

front/src/common/Pathfinding/Pathfinding.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ const Pathfinding = ({ zoomToFeature, path }: PathfindingProps) => {
537537
<div className="pathfinding-state-main-container flex-grow-1">
538538
{infra && infra.state !== 'CACHED' && (
539539
<div className="content infra-loading">
540-
<img src={infraLogo} alt="Infra logo" className="mr-2" />
540+
<img src={infraLogo} alt="Infra logo" className="infra-logo mr-2" />
541541
<div>{t('infraLoading')}</div>
542542
<InfraLoadingState infra={infra} />
543543
</div>

front/src/modules/scenario/components/ScenarioCard.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export default function StudyCard({ setFilterChips, scenario }: StudyCardProps)
6969
</div>
7070
<div className="scenario-card-footer">
7171
<div className="scenario-card-infra">
72-
<img src={infraLogo} alt="infra logo" />
72+
<img src={infraLogo} alt="infra logo" className="infra-logo" />
7373
{scenario.infra_name}
7474
</div>
7575
<div className="scenario-card-trains-count ml-auto">

front/src/modules/study/components/StudyCard.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export default function StudyCard({ setFilterChips, study }: StudyCardProps) {
3333
<div className="study-card">
3434
<div className="study-card-name" data-testid={study.name}>
3535
<span className="mr-2">
36-
<img src={studyLogo} alt="study logo" height="24" />
36+
<img className="study-card-img" src={studyLogo} alt="study logo" />
3737
</span>
3838
<span className="study-card-name-text" title={study.name}>
3939
{study.name}

front/src/modules/trainschedule/components/Timetable/TimetableTrainCard.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ function TimetableTrainCard({
230230
className="mr-1 scenario-timetable-train-invalid-icons"
231231
title={invalidTrainValues.NewerInfra}
232232
>
233-
<img src={invalidInfra} alt="Invalid infra logo" />
233+
<img src={invalidInfra} alt="Invalid infra logo" className="infra-logo" />
234234
</div>
235235
)}
236236
{train.invalid_reasons && train.invalid_reasons.includes('NewerRollingStock') && (

front/src/modules/trainschedule/components/TimetableV2/TimetableTrainCardV2.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ const TimetableTrainCardV2 = ({
230230
className="mr-1 scenario-timetable-train-invalid-icons"
231231
title={invalidTrainValues.NewerInfra}
232232
>
233-
<img src={invalidInfra} alt="Invalid infra logo" />
233+
<img src={invalidInfra} alt="Invalid infra logo" className="infra-logo" />
234234
</div>
235235
)}
236236
{train.invalid_reasons && train.invalid_reasons.includes('NewerRollingStock') && (
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
@import '@osrd-project/ui-core/dist/theme.css';
2+
3+
// https://github.com/tailwindlabs/tailwindcss/issues/942
4+
svg, img {
5+
display:inline-block;
6+
max-width: none;
7+
}
8+
9+
//https://github.com/tailwindlabs/tailwindcss/pull/7742#issuecomment-1061332148
10+
.study-card-img, .map-format-switch-img {
11+
height: 24px;
12+
}
13+
14+
.infra-logo, .icon-to-svg {
15+
height: 16px;
16+
}
17+
18+
.layer-modal-img {
19+
height: 20px;
20+
}
21+
22+
//https://github.com/tailwindlabs/tailwindcss/issues/6602
23+
.error-box button {
24+
background-color: rgb(239, 239, 239);
25+
color: black;
26+
}

front/src/styles/styles.scss

+1
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@
1212
@import 'scss/applications/operationalStudies';
1313
@import 'scss/applications/rollingStockEditor/rollingStockForm';
1414
@import 'scss/applications/stdcm';
15+
@import 'scss/_uiCoreIntegration.scss';

0 commit comments

Comments
 (0)