front: use Date instead of a string in times and stops helpers

Improves type safety.

Signed-off-by: Simon Ser <[email protected]>

Author: emersion

front/src/applications/operationalStudies/views/ManageTrainSchedule.tsx

@@ -40,7 +40,8 @@ const ManageTrainSchedule = ({ trainIdToEdit }: ManageTrainScheduleProps) => {
   const destination = useSelector(getDestination);
   const pathSteps = useSelector(getPathSteps);
   const constraintDistribution = useSelector(getConstraintDistribution);
-  const startTime = useSelector(getStartTime);
+  const rawStartTime = useSelector(getStartTime);
+  const startTime = useMemo(() => new Date(rawStartTime), [rawStartTime]);
 
   const [pathProperties, setPathProperties] = useState<ManageTrainSchedulePathProperties>();
 

front/src/modules/timesStops/TimesStopsInput.tsx

@@ -59,7 +59,7 @@ const createClearViaButton = ({
 
 type TimesStopsInputProps = {
   allWaypoints?: SuggestedOP[];
-  startTime: string;
+  startTime: Date;
   pathSteps: PathStep[];
 };
 

front/src/modules/timesStops/helpers/__tests__/utils.spec.ts

@@ -227,7 +227,7 @@ describe('updateDaySinceDeparture', () => {
           arrival: { time: '10:00:00' },
         },
       ] as TimesStopsInputRow[];
-      const startTime = '2024-08-13T10:00:00';
+      const startTime = new Date('2024-08-13T10:00:00');
       const result = updateDaySinceDeparture(TimesStopsInputRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -261,7 +261,7 @@ describe('updateDaySinceDeparture', () => {
           stopFor: '1800',
         },
       ] as TimesStopsInputRow[];
-      const startTime = '2024-08-13T10:00:00';
+      const startTime = new Date('2024-08-13T10:00:00');
       const result = updateDaySinceDeparture(TimesStopsInputRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -303,7 +303,7 @@ describe('updateDaySinceDeparture', () => {
           arrival: { time: '01:00:00' },
         },
       ] as TimesStopsInputRow[];
-      const startTime = '2024-08-13T00:00:00';
+      const startTime = new Date('2024-08-13T00:00:00');
       const result = updateDaySinceDeparture(pathWaypointRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -346,7 +346,7 @@ describe('updateDaySinceDeparture', () => {
           arrival: { time: '00:30:00' },
         },
       ] as TimesStopsInputRow[];
-      const startTime = '2024-08-13T23:50:00';
+      const startTime = new Date('2024-08-13T23:50:00');
       const result = updateDaySinceDeparture(TimesStopsInputRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -387,7 +387,7 @@ describe('updateDaySinceDeparture', () => {
           arrival: { time: '00:00:00' },
         },
       ] as TimesStopsInputRow[];
-      const startTime = '2024-08-13T23:50:00';
+      const startTime = new Date('2024-08-13T23:50:00');
       const result = updateDaySinceDeparture(pathWaypointRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -435,7 +435,7 @@ describe('updateDaySinceDeparture', () => {
           arrival: { time: '01:30:00' },
         },
       ] as TimesStopsInputRow[];
-      const startTime = '2024-08-13T23:45:00';
+      const startTime = new Date('2024-08-13T23:45:00');
       const result = updateDaySinceDeparture(pathWaypointRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -498,7 +498,7 @@ describe('updateDaySinceDeparture', () => {
           arrival: { time: '00:50:00' },
         },
       ] as TimesStopsInputRow[];
-      const startTime = '2024-08-13T23:50:00';
+      const startTime = new Date('2024-08-13T23:50:00');
       const result = updateDaySinceDeparture(TimesStopsInputRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -563,7 +563,7 @@ describe('updateDaySinceDeparture', () => {
           arrival: { time: '00:56:00' },
         },
       ] as TimesStopsInputRow[];
-      const startTime = '2024-08-13T23:50:00';
+      const startTime = new Date('2024-08-13T23:50:00');
       const result = updateDaySinceDeparture(TimesStopsInputRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -643,7 +643,7 @@ describe('updateDaySinceDeparture', () => {
           stopFor: '3600',
         },
       ] as TimesStopsInputRow[];
-      const startTime = '2024-08-13T23:50:00';
+      const startTime = new Date('2024-08-13T23:50:00');
       const result = updateDaySinceDeparture(TimesStopsInputRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -750,7 +750,7 @@ describe('updateDaySinceDeparture', () => {
         },
       ] as TimesStopsInputRow[];
 
-      const startTime = '2024-08-13T23:45:00';
+      const startTime = new Date('2024-08-13T23:45:00');
       const result = updateDaySinceDeparture(pathWaypointRows, startTime, {
         keepFirstIndexArrival: true,
       });
@@ -812,7 +812,7 @@ describe('updateDaySinceDeparture', () => {
 
 describe('durationSinceStartTime', () => {
   it('should return the correct duration', () => {
-    const startTime = '2023-09-01T10:00:00Z';
+    const startTime = new Date('2023-09-01T10:00:00Z');
     const stepTimeDays = {
       time: '20:00:00',
       daySinceDeparture: 0,
@@ -824,7 +824,7 @@ describe('durationSinceStartTime', () => {
   });
 
   it('should return the correct duration. daySinceDeparture 1', () => {
-    const startTime = '2023-09-01T10:00:00Z';
+    const startTime = new Date('2023-09-01T10:00:00Z');
     const stepTimeDays = {
       time: '11:00:00',
       daySinceDeparture: 1,
@@ -838,7 +838,7 @@ describe('durationSinceStartTime', () => {
 
 describe('calculateStepTimeDays', () => {
   it('should return correct time and daySinceDeparture', () => {
-    const startTime = '2023-09-01T10:00:00Z';
+    const startTime = new Date('2023-09-01T10:00:00Z');
     const isoDuration = 'PT36000S'; // 10 hours
 
     const result = calculateStepTimeAndDays(startTime, isoDuration);
@@ -850,7 +850,7 @@ describe('calculateStepTimeDays', () => {
   });
 
   it('should return correct time and daySinceDeparture, daySinceDeparture 1', () => {
-    const startTime = '2023-09-01T10:00:00Z';
+    const startTime = new Date('2023-09-01T10:00:00Z');
     const isoDuration = 'PT122400S'; // 1 day 10 hours
 
     const result = calculateStepTimeAndDays(startTime, isoDuration);

front/src/modules/timesStops/helpers/utils.ts

@@ -5,7 +5,7 @@ import { round, isEqual, isNil } from 'lodash';
 import { keyColumn, createTextColumn } from 'react-datasheet-grid';
 
 import type { ReceptionSignal } from 'common/api/osrdEditoastApi';
-import type { IsoDateTimeString, IsoDurationString, TimeString } from 'common/types';
+import type { IsoDurationString, TimeString } from 'common/types';
 import { matchPathStepAndOp } from 'modules/pathfinding/utils';
 import type { SuggestedOP } from 'modules/trainschedule/components/ManageTrainSchedule/types';
 import type { PathStep } from 'reducers/osrdconf/types';
@@ -42,7 +42,7 @@ export const formatSuggestedViasToRowVias = (
   operationalPoints: (SuggestedOP & { isWaypoint?: boolean })[],
   pathSteps: PathStep[],
   t: TFunction<'timesStops', undefined>,
-  startTime?: IsoDateTimeString,
+  startTime?: Date,
   tableType?: TableType
 ): TimesStopsInputRow[] => {
   const formattedOps = [...operationalPoints];
@@ -221,11 +221,11 @@ export function normalizeNullablesInRow(row: TimesStopsInputRow): TimesStopsInpu
  */
 export function updateDaySinceDeparture(
   pathWaypointRows: TimesStopsInputRow[],
-  startTime?: IsoDateTimeString,
+  startTime?: Date,
   { keepFirstIndexArrival = false } = {}
 ): TimesStopsInputRow[] {
   let currentDaySinceDeparture = 0;
-  let previousTime = startTime ? datetime2sec(new Date(startTime)) : Number.NEGATIVE_INFINITY;
+  let previousTime = startTime ? datetime2sec(startTime) : Number.NEGATIVE_INFINITY;
 
   return pathWaypointRows.map((pathWaypoint, index) => {
     const { arrival, stopFor } = pathWaypoint;
@@ -282,14 +282,14 @@ export function updateDaySinceDeparture(
 }
 
 export function durationSinceStartTime(
-  startTime?: IsoDateTimeString,
+  startTime?: Date,
   stepTimeDays?: TimeExtraDays
 ): IsoDurationString | null {
   if (!startTime || !stepTimeDays?.time || stepTimeDays?.daySinceDeparture === undefined) {
     return null;
   }
   const start = dayjs(startTime);
-  const step = dayjs(`${startTime.split('T')[0]}T${stepTimeDays.time}`).add(
+  const step = dayjs(`${start.format('YYYY-MM-DD')}T${stepTimeDays.time}`).add(
     stepTimeDays.daySinceDeparture,
     'day'
   );
@@ -299,7 +299,7 @@ export function durationSinceStartTime(
 }
 
 export function calculateStepTimeAndDays(
-  startTime?: IsoDateTimeString | null,
+  startTime?: Date | null,
   isoDuration?: IsoDurationString | null
 ): TimeExtraDays | undefined {
   if (!startTime || !isoDuration) {