front: update stdcm arrival dates when searchDatetimeWindow changes

Signed-off-by: Clara Ni <[email protected]>

Author: clarani

front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useMemo } from 'react';
+import { useMemo } from 'react';
 
 import { DatePicker, Select, TimePicker, TolerancePicker } from '@osrd-project/ui-core';
 import { useTranslation } from 'react-i18next';
@@ -107,20 +107,6 @@ const StdcmOpSchedule = ({
     dispatch(updateStdcmPathStep({ id: pathStep.id, updates: { arrivalType } }));
   };
 
-  useEffect(() => {
-    if (
-      (!isArrivalDateInSearchTimeWindow(arrivalDate, searchDatetimeWindow) ||
-        !opTimingData?.arrivalDate) &&
-      pathStep.arrivalType === 'preciseTime'
-    ) {
-      onArrivalChange({
-        date: defaultDate(searchDatetimeWindow?.begin),
-        hours: arrivalTimeHours || 0,
-        minutes: arrivalTimeMinutes || 0,
-      });
-    }
-  }, [searchDatetimeWindow, pathStep.arrivalType]);
-
   return (
     <>
       <div className="arrival-type-select">

front/src/reducers/osrdconf/stdcmConf/index.ts

@@ -11,6 +11,7 @@ import {
 import { defaultCommonConf, buildCommonConfReducers } from 'reducers/osrdconf/osrdConfCommon';
 import type { OsrdStdcmConfState, StdcmPathStep } from 'reducers/osrdconf/types';
 import { addElementAtIndex } from 'utils/array';
+import { isArrivalDateInSearchTimeWindow } from 'utils/date';
 import type { ArrayElement } from 'utils/types';
 
 const DEFAULT_TOLERANCE = 1800; // 30min
@@ -127,11 +128,34 @@ export const stdcmConfSlice = createSlice({
       state.timetableID = action.payload.timetableID;
       state.electricalProfileSetId = action.payload.electricalProfileSetId;
       state.searchDatetimeWindow = action.payload.searchDatetimeWindow;
-      if (action.payload.workScheduleGroupId) {
-        state.workScheduleGroupId = action.payload.workScheduleGroupId;
-      }
-      if (action.payload.temporarySpeedLimitGroupId) {
-        state.temporarySpeedLimitGroupId = action.payload.temporarySpeedLimitGroupId;
+      state.workScheduleGroupId = action.payload.workScheduleGroupId;
+      state.temporarySpeedLimitGroupId = action.payload.temporarySpeedLimitGroupId;
+
+      // check that the arrival dates are in the search time window
+      const { searchDatetimeWindow } = action.payload;
+      if (searchDatetimeWindow) {
+        const origin = state.stdcmPathSteps.at(0)! as Extract<StdcmPathStep, { isVia: false }>;
+        const destination = state.stdcmPathSteps.at(-1)! as Extract<
+          StdcmPathStep,
+          { isVia: false }
+        >;
+        let newOrigin = origin;
+        let newDestination = destination;
+
+        if (
+          !origin.arrival ||
+          !isArrivalDateInSearchTimeWindow(origin.arrival, searchDatetimeWindow)
+        ) {
+          newOrigin = { ...origin, arrival: searchDatetimeWindow.begin };
+        }
+        if (
+          !destination.arrival ||
+          !isArrivalDateInSearchTimeWindow(destination.arrival, searchDatetimeWindow)
+        ) {
+          newDestination = { ...destination, arrival: searchDatetimeWindow.end };
+        }
+
+        state.stdcmPathSteps = [newOrigin, ...state.stdcmPathSteps.slice(1, -1), newDestination];
       }
     },
     updateStdcmPathSteps(

front/src/reducers/osrdconf/types.ts

@@ -102,6 +102,7 @@ export type StdcmPathStep = {
   | {
       isVia: false;
       arrivalType: ArrivalTimeTypes;
+      // TODO: make arrival non nullable (/!\ store migration)
       arrival?: Date;
       tolerances?: { before: number; after: number };
     }