core: ignore scheduled points that are impossible

Author: eckter

core/osrd-reporting/src/main/java/fr/sncf/osrd/reporting/exceptions/ErrorType.java

@@ -70,7 +70,6 @@ public enum ErrorType {
     InvalidRollingStockField("invalid_rolling_stock_field", "Invalid rolling stock field", ErrorCause.USER),
     MissingRollingStockField("missing_rolling_stock_field", "missing rolling stock field", ErrorCause.USER),
 
-    ImpossibleScheduledPoints("invalid_schedule", "Impossible to follow scheduled points", ErrorCause.USER),
     InvalidScheduleTrackDoesNotExist(
             "invalid_schedule", "Track %s referenced in path step does not exist", ErrorCause.USER),
     InvalidScheduleTrackLocationNotIncludedInPath(

core/src/main/kotlin/fr/sncf/osrd/standalone_sim/StandaloneSimulation.kt

@@ -18,8 +18,6 @@ import fr.sncf.osrd.envelope_sim_infra.EnvelopeTrainPath
 import fr.sncf.osrd.envelope_sim_infra.MRSP
 import fr.sncf.osrd.external_generated_inputs.ElectricalProfileMapping
 import fr.sncf.osrd.railjson.schema.schedule.RJSAllowanceDistribution
-import fr.sncf.osrd.reporting.exceptions.ErrorType
-import fr.sncf.osrd.reporting.exceptions.OSRDError
 import fr.sncf.osrd.sim_infra.api.Path
 import fr.sncf.osrd.sim_infra.api.PathProperties
 import fr.sncf.osrd.sim_infra.api.Route
@@ -193,12 +191,10 @@ fun buildFinalEnvelope(
         val sectionTime =
             getEnvelopeTimeAt(point.pathOffset) - getEnvelopeTimeAt(prevFixedPointOffset)
         val arrivalTime = prevFixedPointDepartureTime + sectionTime
-        val extraTime = point.arrival.seconds - arrivalTime
+        var extraTime = point.arrival.seconds - arrivalTime
         if (extraTime < 0.0) {
-            val error = OSRDError(ErrorType.ImpossibleScheduledPoints)
-            error.context["scheduled_points"] = scheduledPoints
-            error.context["index"] = i
-            throw error
+            // TODO: raise a warning
+            extraTime = 0.0
         }
         marginRanges.addAll(
             distributeAllowance(
@@ -211,7 +207,7 @@ fun buildFinalEnvelope(
             )
         )
         prevFixedPointOffset = point.pathOffset
-        prevFixedPointDepartureTime = point.arrival.seconds + (point.stopFor?.seconds ?: 0.0)
+        prevFixedPointDepartureTime = arrivalTime + extraTime + (point.stopFor?.seconds ?: 0.0)
     }
     val pathEnd = Offset<Path>(maxEffortEnvelope.endPos.meters)
     if (prevFixedPointOffset < pathEnd) {