front: fix allowances do not reset when changing the path

Author: clarani

front/public/locales/en/operationalStudies/manageTrainSchedule.json

@@ -116,6 +116,8 @@
   "warningMessages": {
     "electrification": "Electrification",
     "powerRestrictionInvalidCombination": "{{powerRestrictionCode}} is incompatible with electrification {{electrification}} of the path between {{begin}}m and {{end}}m",
-    "missingPowerRestriction": "Missing power restriction between {{begin}}m and {{end}}m. "
+    "missingPowerRestriction": "Missing power restriction between {{begin}}m and {{end}}m.",
+    "pathfindingChange": "Pathfinding changed",
+    "marginsAndPowerRestrictionsReset": "Margins and power restrictions have been reset."
   }
 }

front/public/locales/fr/operationalStudies/manageTrainSchedule.json

@@ -116,6 +116,8 @@
   "warningMessages": {
     "electrification": "Électrification",
     "powerRestrictionInvalidCombination": "Code {{powerRestrictionCode}} incompatible avec l'électrification à {{electrification}} de l'itinéraire entre {{begin}}m et {{end}}m. ",
-    "missingPowerRestriction": "Restriction de puissance manquante entre {{begin}}m et {{end}}m. "
+    "missingPowerRestriction": "Restriction de puissance manquante entre {{begin}}m et {{end}}m.",
+    "pathfindingChange": "Changement de chemin",
+    "marginsAndPowerRestrictionsReset": "Les marges et les restrictions de puissance ont été réinitialisées."
   }
 }

front/src/common/Pathfinding/Pathfinding.tsx

@@ -14,8 +14,9 @@ import type { PathResponse, PathfindingRequest, PathfindingStep } from 'common/a
 import { osrdEditoastApi } from 'common/api/osrdEditoastApi';
 import { Spinner } from 'common/Loaders';
 import { useOsrdConfActions, useOsrdConfSelectors } from 'common/osrdContext';
-import { setFailure } from 'reducers/main';
+import { setFailure, setWarning } from 'reducers/main';
 import { useAppDispatch } from 'store';
+import { isEmptyArray } from 'utils/array';
 import { castErrorToFailure } from 'utils/error';
 import { conditionalStringConcat, formatKmValue } from 'utils/strings';
 import type { ArrayElement } from 'utils/types';
@@ -245,7 +246,7 @@ export function getPathfindingQuery({
   return null;
 }
 
-function Pathfinding({ zoomToFeature, path }: PathfindingProps) {
+const Pathfinding = ({ zoomToFeature, path }: PathfindingProps) => {
   const { t } = useTranslation(['operationalStudies/manageTrainSchedule']);
   const [pathfindingRequest, setPathfindingRequest] =
     useState<ReturnType<typeof postPathfinding>>();
@@ -258,6 +259,8 @@ function Pathfinding({ zoomToFeature, path }: PathfindingProps) {
     getRollingStockID,
     getPathfindingID,
     getGeojson,
+    getPowerRestrictionRanges,
+    getAllowances,
   } = useOsrdConfSelectors();
   const infraID = useSelector(getInfraID, isEqual);
   const origin = useSelector(getOrigin, isEqual);
@@ -266,6 +269,8 @@ function Pathfinding({ zoomToFeature, path }: PathfindingProps) {
   const rollingStockID = useSelector(getRollingStockID, isEqual);
   const pathfindingID = useSelector(getPathfindingID, isEqual);
   const geojson = useSelector(getGeojson, isEqual);
+  const powerRestrictions = useSelector(getPowerRestrictionRanges, isEqual);
+  const allowances = useSelector(getAllowances, isEqual);
   const initializerArgs = {
     pathfindingID,
     geojson,
@@ -291,8 +296,14 @@ function Pathfinding({ zoomToFeature, path }: PathfindingProps) {
   );
   const [reloadInfra] = osrdEditoastApi.usePostInfraByIdLoadMutation();
 
-  const { replaceVias, updateItinerary, updatePathfindingID, updateSuggeredVias } =
-    useOsrdConfActions();
+  const {
+    replaceVias,
+    updateItinerary,
+    updatePathfindingID,
+    updateSuggeredVias,
+    updatePowerRestrictionRanges,
+    updateAllowances,
+  } = useOsrdConfActions();
 
   useEffect(() => {
     if (reloadCount <= 5 && infra && infra.state === 'TRANSIENT_ERROR') {
@@ -415,6 +426,17 @@ function Pathfinding({ zoomToFeature, path }: PathfindingProps) {
           dispatch(updatePathfindingID(itineraryCreated.id));
           if (zoom) zoomToFeature(bbox(itineraryCreated.geographic));
           pathfindingDispatch({ type: 'PATHFINDING_FINISHED' });
+
+          if (!isEmptyArray(powerRestrictions) || !isEmptyArray(allowances)) {
+            dispatch(updatePowerRestrictionRanges([]));
+            dispatch(updateAllowances([]));
+            dispatch(
+              setWarning({
+                title: t('warningMessages.pathfindingChange'),
+                text: t('warningMessages.marginsAndPowerRestrictionsReset'),
+              })
+            );
+          }
         })
         .catch((e) => {
           if (e.error) {
@@ -571,6 +593,6 @@ function Pathfinding({ zoomToFeature, path }: PathfindingProps) {
       )}
     </div>
   );
-}
+};
 
 export default Pathfinding;

front/src/reducers/osrdconf/osrdConfCommon/__tests__/utils.ts

@@ -146,7 +146,6 @@ const testCommonConfReducers = (slice: OperationalStudiesConfSlice | StdcmConfSl
     defaultStore.dispatch(slice.actions.updatePathfindingID(newPathfindingID));
     const state = defaultStore.getState()[slice.name];
     expect(state.pathfindingID).toBe(newPathfindingID);
-    expect(state.powerRestrictionRanges).toStrictEqual([]);
   });
 
   it('should handle updateTimetableID', () => {

front/src/reducers/osrdconf/osrdConfCommon/index.ts

@@ -137,7 +137,6 @@ export function buildCommonConfReducers<S extends OsrdConfState>(): CommonConfRe
     },
     updatePathfindingID(state: Draft<S>, action: PayloadAction<S['pathfindingID']>) {
       state.pathfindingID = action.payload;
-      state.powerRestrictionRanges = [];
     },
     updateTimetableID(state: Draft<S>, action: PayloadAction<S['timetableID']>) {
       state.timetableID = action.payload;

front/src/utils/array.ts

@@ -1,6 +1,8 @@
 export const isFirstOrLastElement = <T>(array: T[], element: T) =>
   array[0] === element || array[array.length - 1] === element;
 
+export const isEmptyArray = <T>(array: T[]) => array.length;
+
 /**
  * Take an array of strings, sort it and split it in two : one array of letter starting strings and one with digit or special characters starting strings.
  */