editoast: fix clippy warnings

Author: leovalais

editoast/src/schema/railjson.rs

@@ -176,10 +176,7 @@ pub mod test {
         assert!(check_objects_eq(&s_railjson.detectors, &railjson.detectors));
     }
 
-    fn check_objects_eq<T: PartialEq + OSRDIdentified>(
-        objects: &Vec<T>,
-        expected: &Vec<T>,
-    ) -> bool {
+    fn check_objects_eq<T: PartialEq + OSRDIdentified>(objects: &[T], expected: &[T]) -> bool {
         assert_eq!(objects.len(), expected.len());
         let map_expected: HashMap<_, _> = expected.iter().map(|obj| (obj.get_id(), obj)).collect();
 

editoast/src/views/infra/objects.rs

@@ -1,4 +1,4 @@
-use std::collections::HashMap;
+use std::collections::{HashMap, HashSet};
 
 use actix_web::dev::HttpServiceFactory;
 use actix_web::post;
@@ -31,11 +31,8 @@ enum GetObjectsErrors {
 }
 
 /// Return whether the list of ids contains unique values or has duplicate
-fn has_unique_ids(obj_ids: &Vec<String>) -> bool {
-    let mut obj_ids_2 = obj_ids.clone();
-    obj_ids_2.sort();
-    obj_ids_2.dedup();
-    obj_ids_2.len() == obj_ids.len()
+fn has_unique_ids(obj_ids: &[String]) -> bool {
+    obj_ids.len() == obj_ids.iter().collect::<HashSet<_>>().len()
 }
 
 #[derive(QueryableByName, Debug, Clone, Serialize, Deserialize, PartialEq)]

editoast/src/views/infra/pathfinding.rs

@@ -313,7 +313,7 @@ fn compute_path(
         .collect()
 }
 
-fn build_path_output(path: &Vec<PathfindingStep>, infra_cache: &InfraCache) -> PathfindingOutput {
+fn build_path_output(path: &[PathfindingStep], infra_cache: &InfraCache) -> PathfindingOutput {
     // Fill track ranges
     let mut track_ranges = Vec::new();
     // We ignore the first element of path, as it is a virtual step to handle going in both directions