front: remove StdcmConfSliceActions casts

Signed-off-by: Clara Ni <[email protected]>

Author: clarani

front/src/applications/stdcm/components/StdcmForm/StdcmConfig.tsx

@@ -12,11 +12,11 @@ import {
   validateTotalLength,
   validateTotalMass,
 } from 'applications/stdcm/utils/consistValidation';
-import { useOsrdConfActions, useOsrdConfSelectors } from 'common/osrdContext';
+import { useOsrdConfSelectors } from 'common/osrdContext';
 import useInfraStatus from 'modules/pathfinding/hooks/useInfraStatus';
 import { useStoreDataForRollingStockSelector } from 'modules/rollingStock/components/RollingStockSelector/useStoreDataForRollingStockSelector';
 import NewMap from 'modules/trainschedule/components/ManageTrainSchedule/NewMap';
-import { type StdcmConfSliceActions, resetMargins } from 'reducers/osrdconf/stdcmConf';
+import { resetMargins, restoreStdcmConfig, updateStdcmPathStep } from 'reducers/osrdconf/stdcmConf';
 import {
   getMaxSpeed,
   getStdcmDestination,
@@ -73,7 +73,6 @@ const StdcmConfig = ({
 
   const { infra } = useInfraStatus();
   const dispatch = useAppDispatch();
-  const { updateStdcmPathStep, restoreStdcmConfig } = useOsrdConfActions() as StdcmConfSliceActions;
 
   const { getProjectID, getScenarioID, getStudyID } = useOsrdConfSelectors();
   const origin = useSelector(getStdcmOrigin);

front/src/applications/stdcm/components/StdcmForm/StdcmConsist.tsx

@@ -16,7 +16,7 @@ import RollingStock2Img from 'modules/rollingStock/components/RollingStock2Img';
 import { useStoreDataForRollingStockSelector } from 'modules/rollingStock/components/RollingStockSelector/useStoreDataForRollingStockSelector';
 import useFilterRollingStock from 'modules/rollingStock/hooks/useFilterRollingStock';
 import useFilterTowedRollingStock from 'modules/towedRollingStock/hooks/useFilterTowedRollingStock';
-import { type StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
+import { updateTowedRollingStockID } from 'reducers/osrdconf/stdcmConf';
 import { useAppDispatch } from 'store';
 import { kgToT, kmhToMs, msToKmh } from 'utils/physics';
 
@@ -48,8 +48,7 @@ const StdcmConsist = ({ isDebugMode, consistErrors = {}, disabled = false }: Std
   const { speedLimitByTag, speedLimitsByTags, dispatchUpdateSpeedLimitByTag } =
     useStoreDataForSpeedLimitByTagSelector({ isStdcm: true });
 
-  const { updateRollingStockID, updateTowedRollingStockID } =
-    useOsrdConfActions() as StdcmConfSliceActions;
+  const { updateRollingStockID } = useOsrdConfActions();
   const dispatch = useAppDispatch();
 
   const { rollingStock } = useStoreDataForRollingStockSelector();

front/src/applications/stdcm/components/StdcmForm/StdcmLinkedTrainResults.tsx

@@ -2,8 +2,7 @@ import { RadioButton } from '@osrd-project/ui-core';
 import cx from 'classnames';
 import { useDispatch } from 'react-redux';
 
-import { useOsrdConfActions } from 'common/osrdContext';
-import type { StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
+import { updateLinkedTrainExtremity } from 'reducers/osrdconf/stdcmConf';
 
 import type { StdcmLinkedTrainResult, ExtremityPathStepType } from '../../types';
 
@@ -17,7 +16,6 @@ const StdcmLinkedTrainResults = ({
   linkedOp: { extremityType, id },
 }: StdcmLinkedTrainResultsProps) => {
   const dispatch = useDispatch();
-  const { updateLinkedTrainExtremity } = useOsrdConfActions() as StdcmConfSliceActions;
   return (
     <div className="stdcm-linked-train-results">
       {linkedTrainResults.map(({ trainName, origin, destination }, index) => (

front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx

@@ -4,8 +4,8 @@ import { DatePicker, Select, TimePicker, TolerancePicker } from '@osrd-project/u
 import { useTranslation } from 'react-i18next';
 import { useSelector } from 'react-redux';
 
-import { useOsrdConfActions, useOsrdConfSelectors } from 'common/osrdContext';
-import type { StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
+import { useOsrdConfSelectors } from 'common/osrdContext';
+import { updateStdcmPathStep } from 'reducers/osrdconf/stdcmConf';
 import type { StdcmPathStep } from 'reducers/osrdconf/types';
 import { useAppDispatch } from 'store';
 import { formatDateString } from 'utils/date';
@@ -24,7 +24,6 @@ const StdcmOpSchedule = ({ disabled, pathStep, opId, isOrigin = false }: StdcmOp
   const { t } = useTranslation('stdcm');
   const dispatch = useAppDispatch();
 
-  const { updateStdcmPathStep } = useOsrdConfActions() as StdcmConfSliceActions;
   const { getSearchDatetimeWindow } = useOsrdConfSelectors();
   const searchDatetimeWindow = useSelector(getSearchDatetimeWindow);
 

front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx

@@ -5,8 +5,7 @@ import { useTranslation } from 'react-i18next';
 
 import type { SearchResultItemOperationalPoint } from 'common/api/osrdEditoastApi';
 import useSearchOperationalPoint from 'common/Map/Search/useSearchOperationalPoint';
-import { useOsrdConfActions } from 'common/osrdContext';
-import type { StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
+import { updateStdcmPathStep } from 'reducers/osrdconf/stdcmConf';
 import type { StdcmPathStep } from 'reducers/osrdconf/types';
 import { useAppDispatch } from 'store';
 import { normalized } from 'utils/strings';
@@ -55,8 +54,6 @@ const StdcmOperationalPoint = ({ location, pathStepId, disabled }: StdcmOperatio
 
   const [chSuggestions, setChSuggestions] = useState<CHOption[]>([]);
 
-  const { updateStdcmPathStep } = useOsrdConfActions() as StdcmConfSliceActions;
-
   const selectedCi = useMemo(
     () =>
       location

front/src/applications/stdcm/components/StdcmForm/StdcmVias.tsx

@@ -5,8 +5,7 @@ import { useTranslation } from 'react-i18next';
 import { useSelector } from 'react-redux';
 
 import IntermediatePointIcon from 'assets/pictures/mapMarkers/intermediate-point.svg';
-import { useOsrdConfActions } from 'common/osrdContext';
-import type { StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
+import { updateStdcmPathStep, deleteStdcmVia, addStdcmVia } from 'reducers/osrdconf/stdcmConf';
 import { getStdcmPathSteps } from 'reducers/osrdconf/stdcmConf/selectors';
 import type { StdcmPathStep } from 'reducers/osrdconf/types';
 import { useAppDispatch } from 'store';
@@ -22,8 +21,6 @@ import type { StdcmConfigCardProps } from '../../types';
 const StdcmVias = ({ disabled = false }: StdcmConfigCardProps) => {
   const { t } = useTranslation('stdcm');
   const dispatch = useAppDispatch();
-  const { updateStdcmPathStep, addStdcmVia, deleteStdcmVia } =
-    useOsrdConfActions() as StdcmConfSliceActions;
   const pathSteps = useSelector(getStdcmPathSteps);
 
   const [newIntermediateOpIndex, setNewIntermediateOpIndex] = useState<number>();

front/src/applications/stdcm/components/StdcmForm/StopDurationInput.tsx

@@ -4,8 +4,7 @@ import { Input } from '@osrd-project/ui-core';
 import type { Status } from '@osrd-project/ui-core/dist/components/inputs/StatusMessage';
 import { useTranslation } from 'react-i18next';
 
-import { useOsrdConfActions } from 'common/osrdContext';
-import type { StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
+import { updateStdcmPathStep } from 'reducers/osrdconf/stdcmConf';
 import type { StdcmPathStep } from 'reducers/osrdconf/types';
 import { useAppDispatch } from 'store';
 import { useDebounce } from 'utils/helpers';
@@ -21,8 +20,6 @@ const StopDurationInput = ({ pathStep }: StopDurationInputProps) => {
   const dispatch = useAppDispatch();
   const { t } = useTranslation('stdcm');
 
-  const { updateStdcmPathStep } = useOsrdConfActions() as StdcmConfSliceActions;
-
   const [stopDuration, setStopDuration] = useState(
     pathStep.stopFor !== undefined ? `${pathStep.stopFor}` : ''
   );

front/src/applications/stdcm/hooks/useStdcmConsist.ts

@@ -4,8 +4,7 @@ import { min } from 'lodash';
 import { useSelector } from 'react-redux';
 
 import type { LightRollingStockWithLiveries, TowedRollingStock } from 'common/api/osrdEditoastApi';
-import { useOsrdConfActions } from 'common/osrdContext';
-import { type StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
+import { updateTotalMass, updateTotalLength, updateMaxSpeed } from 'reducers/osrdconf/stdcmConf';
 import { getTotalMass, getTotalLength, getMaxSpeed } from 'reducers/osrdconf/stdcmConf/selectors';
 import { useAppDispatch } from 'store';
 import { kgToT, kmhToMs, msToKmh } from 'utils/physics';
@@ -19,9 +18,6 @@ const useStdcmConsist = () => {
   const [totalLengthChanged, setTotalLengthChanged] = useState(false);
   const [maxSpeedChanged, setMaxSpeedChanged] = useState(false);
 
-  const { updateTotalMass, updateTotalLength, updateMaxSpeed } =
-    useOsrdConfActions() as StdcmConfSliceActions;
-
   const totalMass = useSelector(getTotalMass);
   const onTotalMassChange = (e: React.ChangeEvent<HTMLInputElement>) => {
     const totalMassValue = Number(e.target.value);

front/src/applications/stdcm/hooks/useStdcmEnv.tsx

@@ -3,14 +3,12 @@ import { useCallback, useEffect, useState } from 'react';
 import { useDispatch } from 'react-redux';
 
 import { osrdEditoastApi } from 'common/api/osrdEditoastApi';
-import { useOsrdConfActions } from 'common/osrdContext';
-import type { StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
+import { updateStdcmEnvironment } from 'reducers/osrdconf/stdcmConf';
 
 export const NO_CONFIG_FOUND_MSG = 'No configuration found';
 
 export default function useStdcmEnvironment() {
   const dispatch = useDispatch();
-  const { updateStdcmEnvironment } = useOsrdConfActions() as StdcmConfSliceActions;
   const [getStdcmSearchEnvironment] =
     osrdEditoastApi.endpoints.getStdcmSearchEnvironment.useLazyQuery();
 

front/src/modules/scenario/components/ScenarioExplorer/ScenarioExplorer.tsx

@@ -13,9 +13,9 @@ import { getDocument } from 'common/api/documentApi';
 import { osrdEditoastApi } from 'common/api/osrdEditoastApi';
 import { useModal } from 'common/BootstrapSNCF/ModalSNCF';
 import { LoaderFill } from 'common/Loaders';
-import { useOsrdConfActions, useOsrdConfSelectors } from 'common/osrdContext';
+import { useOsrdConfSelectors } from 'common/osrdContext';
 import { getScenarioDatetimeWindow } from 'modules/scenario/helpers/utils';
-import type { StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
+import { updateStdcmEnvironment } from 'reducers/osrdconf/stdcmConf';
 import { useAppDispatch } from 'store';
 
 import ScenarioExplorerModal, { type ScenarioExplorerProps } from './ScenarioExplorerModal';
@@ -35,7 +35,6 @@ const ScenarioExplorer = ({
   const timetableID = useSelector(getTimetableID);
   const [imageUrl, setImageUrl] = useState<string>();
 
-  const { updateStdcmEnvironment } = useOsrdConfActions() as StdcmConfSliceActions;
   const { data: projectDetails } = osrdEditoastApi.endpoints.getProjectsByProjectId.useQuery(
     { projectId: globalProjectId! },
     { skip: !globalProjectId }

front/src/reducers/osrdconf/stdcmConf/index.ts

@@ -268,21 +268,31 @@ export const stdcmConfSlice = createSlice({
   },
 });
 
-export const stdcmConfSliceActions = stdcmConfSlice.actions;
-
 export const {
+  resetStdcmConfig,
+  restoreStdcmConfig,
+  updateTotalMass,
+  updateTotalLength,
+  updateMaxSpeed,
+  updateTowedRollingStockID,
   resetMargins,
   updateGridMarginAfter,
   updateGridMarginBefore,
   updateStandardAllowance,
+  updateStdcmEnvironment,
+  updateStdcmPathSteps,
+  updateStdcmPathStep,
+  addStdcmVia,
+  deleteStdcmVia,
+  updateLinkedTrainExtremity,
   addNewStdcmResult,
   updateLastStdcmResult,
   selectSimulation,
   retainSimulation,
-} = stdcmConfSliceActions;
+} = stdcmConfSlice.actions;
 
 export type StdcmConfSlice = typeof stdcmConfSlice;
 
-export type StdcmConfSliceActions = typeof stdcmConfSliceActions;
+export type StdcmConfSliceActions = typeof stdcmConfSlice.actions;
 
 export default stdcmConfSlice.reducer;

front/src/reducers/osrdconf/stdcmConf/stdcmConfReducers.spec.ts

@@ -2,13 +2,21 @@ import { describe, it, expect } from 'vitest';
 
 import { ArrivalTimeTypes, StdcmStopTypes } from 'applications/stdcm/types';
 import {
-  addNewStdcmResult,
-  retainSimulation,
-  selectSimulation,
   stdcmConfInitialState,
   stdcmConfSlice,
-  stdcmConfSliceActions,
   updateLastStdcmResult,
+  resetStdcmConfig,
+  updateGridMarginAfter,
+  updateGridMarginBefore,
+  updateMaxSpeed,
+  updateStandardAllowance,
+  updateStdcmPathStep,
+  updateTotalLength,
+  updateTotalMass,
+  updateTowedRollingStockID,
+  addNewStdcmResult,
+  retainSimulation,
+  selectSimulation,
 } from 'reducers/osrdconf/stdcmConf';
 import type { OsrdStdcmConfState, StandardAllowance, StdcmPathStep } from 'reducers/osrdconf/types';
 import { createStoreWithoutMiddleware } from 'store';
@@ -83,7 +91,7 @@ describe('stdcmConfReducers', () => {
       expect(stateBefore.margins.standardAllowance).toBe(initialTimeStandardAllowance);
 
       const newStandardAllowance = testDataBuilder.buildPercentageStandardAllowance(5);
-      store.dispatch(stdcmConfSliceActions.updateStandardAllowance(newStandardAllowance));
+      store.dispatch(updateStandardAllowance(newStandardAllowance));
 
       const stateAfter = store.getState()[stdcmConfSlice.name];
       expect(stateAfter.margins.standardAllowance).toBe(newStandardAllowance);
@@ -92,23 +100,23 @@ describe('stdcmConfReducers', () => {
     it('should handle updateGridMarginBefore', () => {
       const newGridMarginBefore = 5;
       const store = createStore(initialStateSTDCMConfig);
-      store.dispatch(stdcmConfSliceActions.updateGridMarginBefore(newGridMarginBefore));
+      store.dispatch(updateGridMarginBefore(newGridMarginBefore));
       const state = store.getState()[stdcmConfSlice.name];
       expect(state.margins.gridMarginBefore).toStrictEqual(newGridMarginBefore);
     });
 
     it('should handle updateGridMarginAfter', () => {
       const newGridMarginAfter = 5;
       const store = createStore(initialStateSTDCMConfig);
-      store.dispatch(stdcmConfSliceActions.updateGridMarginAfter(newGridMarginAfter));
+      store.dispatch(updateGridMarginAfter(newGridMarginAfter));
       const state = store.getState()[stdcmConfSlice.name];
       expect(state.margins.gridMarginAfter).toStrictEqual(newGridMarginAfter);
     });
   });
 
   it('should handle resetStdcmConfig', () => {
     const store = createStore(initialStateSTDCMConfig);
-    store.dispatch(stdcmConfSliceActions.resetStdcmConfig());
+    store.dispatch(resetStdcmConfig());
 
     const state = store.getState()[stdcmConfSlice.name];
     expect(state.rollingStockID).toBe(stdcmConfInitialState.rollingStockID);
@@ -119,23 +127,23 @@ describe('stdcmConfReducers', () => {
   describe('Consist updates', () => {
     const store = createStore();
     it('should handle totalMass', () => {
-      store.dispatch(stdcmConfSliceActions.updateTotalMass(345));
+      store.dispatch(updateTotalMass(345));
       const state = store.getState()[stdcmConfSlice.name];
       expect(state.totalMass).toEqual(345);
     });
 
     it('should handle totalLength', () => {
-      store.dispatch(stdcmConfSliceActions.updateTotalLength(345));
+      store.dispatch(updateTotalLength(345));
       const state = store.getState()[stdcmConfSlice.name];
       expect(state.totalLength).toEqual(345);
     });
     it('should handle maxSpeed', () => {
-      store.dispatch(stdcmConfSliceActions.updateMaxSpeed(110));
+      store.dispatch(updateMaxSpeed(110));
       const state = store.getState()[stdcmConfSlice.name];
       expect(state.maxSpeed).toEqual(110);
     });
     it('should handle towedRollingStockID', () => {
-      store.dispatch(stdcmConfSliceActions.updateTowedRollingStockID(11));
+      store.dispatch(updateTowedRollingStockID(11));
       const state = store.getState()[stdcmConfSlice.name];
       expect(state.towedRollingStockID).toEqual(11);
     });
@@ -156,7 +164,7 @@ describe('stdcmConfReducers', () => {
         },
       };
 
-      store.dispatch(stdcmConfSliceActions.updateStdcmPathStep({ id: origin.id, updates }));
+      store.dispatch(updateStdcmPathStep({ id: origin.id, updates }));
       const state = store.getState()[stdcmConfSlice.name];
       expect(state.stdcmPathSteps.at(0)).toEqual({ ...origin, ...updates });
     });
@@ -169,7 +177,7 @@ describe('stdcmConfReducers', () => {
         stopFor: 1,
       };
 
-      store.dispatch(stdcmConfSliceActions.updateStdcmPathStep({ id: via.id, updates }));
+      store.dispatch(updateStdcmPathStep({ id: via.id, updates }));
       const state = store.getState()[stdcmConfSlice.name];
       expect(state.stdcmPathSteps.at(1)).toEqual({ ...via, ...updates });
     });
@@ -186,7 +194,7 @@ describe('stdcmConfReducers', () => {
         },
       };
 
-      store.dispatch(stdcmConfSliceActions.updateStdcmPathStep({ id: destination.id, updates }));
+      store.dispatch(updateStdcmPathStep({ id: destination.id, updates }));
       const state = store.getState()[stdcmConfSlice.name];
       expect(state.stdcmPathSteps.at(-1)).toEqual({ ...destination, ...updates });
     });