Skip to content

Commit 416ae4a

Browse files
committed
editoast: adding postgresql-client to running image for debug and maintenance
Signed-off-by: ElysaSrc <[email protected]>
1 parent 5c64157 commit 416ae4a

File tree

3 files changed

+12
-50
lines changed

3 files changed

+12
-50
lines changed

editoast/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ RUN --mount=type=cache,target=/usr/local/cargo/registry \
5656
# Running env #
5757
###############
5858
FROM alpine:3.20 AS running_env
59-
RUN apk add --no-cache jemalloc curl ca-certificates geos libpq openssl
59+
RUN apk add --no-cache jemalloc curl ca-certificates geos libpq openssl postgresql16-client
6060

6161
COPY --from=run_builder /usr/local/cargo/bin/editoast /usr/local/bin/editoast
6262
COPY --from=run_builder /usr/local/cargo/bin/diesel /usr/local/bin/diesel

osrdyne/src/config.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ impl Default for OsrdyneConfig {
3838
fn default() -> Self {
3939
Self {
4040
amqp_uri: "amqp://osrd:password@osrd-rabbitmq:5672/%2f".into(),
41-
management_uri: "http://osrd:password@osrd-rabbitmq:15672/%2f".into(),
41+
management_uri: "http://osrd:password@osrd-rabbitmq:15672".into(),
4242
pool_id: "core".to_string(),
4343
worker_driver: WorkerDriverConfig::Noop,
4444
worker_loop_interval: Duration::from_millis(500),

osrdyne/src/management_client.rs

+10-48
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ use crate::config::OsrdyneConfig;
99
pub struct ManagementClient {
1010
client: reqwest::Client,
1111
base: url::Url,
12-
user: String,
13-
password: String,
1412
vhost: String,
1513
}
1614

@@ -82,24 +80,9 @@ impl ManagementClient {
8280
s => &s[1..],
8381
};
8482

85-
let password = parsed_uri.password().unwrap_or("guest");
86-
let user = match parsed_uri.username() {
87-
"" => "guest",
88-
username => username,
89-
};
90-
91-
let recomposed_base_uri = format!(
92-
"{}://{}:{}",
93-
parsed_uri.scheme(),
94-
parsed_uri.host_str().unwrap(),
95-
parsed_uri.port().unwrap_or(15672)
96-
);
97-
9883
Ok(Self {
9984
client: reqwest::Client::new(),
100-
base: recomposed_base_uri.parse()?,
101-
user: user.into(),
102-
password: password.into(),
85+
base: parsed_uri.clone(),
10386
vhost: vhost.into(),
10487
})
10588
}
@@ -110,13 +93,7 @@ impl ManagementClient {
11093
rel_url: impl AsRef<str>,
11194
) -> anyhow::Result<Request> {
11295
let url = self.base.join(rel_url.as_ref())?;
113-
let username = self.user.clone();
114-
let password = self.password.clone();
115-
let request = self
116-
.client
117-
.request(method, url)
118-
.basic_auth(username, Some(password))
119-
.build()?;
96+
let request = self.client.request(method, url).build()?;
12097
Ok(request)
12198
}
12299

@@ -169,10 +146,11 @@ mod tests {
169146

170147
let client = ManagementClient::try_from(&config).expect("failed to create client");
171148

172-
assert_eq!(client.user, "osrd1");
173-
assert_eq!(client.password, "password1");
174149
assert_eq!(client.vhost, "%2f");
175-
assert_eq!("http://osrd-rabbitmq:15672/", client.base.as_str());
150+
assert_eq!(
151+
"http://osrd1:password1@osrd-rabbitmq:15672/",
152+
client.base.as_str()
153+
);
176154
}
177155

178156
#[test]
@@ -186,26 +164,10 @@ mod tests {
186164
};
187165

188166
let client = ManagementClient::try_from(&config).expect("failed to create client");
189-
assert_eq!(client.user, "osrd1");
190-
assert_eq!(client.password, "password1");
191-
assert_eq!(client.vhost, "%2f");
192-
assert_eq!("http://127.0.0.1:15672/", client.base.as_str());
193-
}
194-
195-
#[test]
196-
fn try_from_no_port_given() {
197-
let amqp_uri = "amqp://osrd:[email protected]:5672/%2f";
198-
let mgmt_uri = "http://osrd1:[email protected]";
199-
let config = OsrdyneConfig {
200-
amqp_uri: amqp_uri.into(),
201-
management_uri: mgmt_uri.into(),
202-
..Default::default()
203-
};
204-
205-
let client = ManagementClient::try_from(&config).expect("failed to create client");
206-
assert_eq!(client.user, "osrd1");
207-
assert_eq!(client.password, "password1");
208167
assert_eq!(client.vhost, "%2f");
209-
assert_eq!("http://127.0.0.1:15672/", client.base.as_str());
168+
assert_eq!(
169+
"http://osrd1:[email protected]:15672/",
170+
client.base.as_str()
171+
);
210172
}
211173
}

0 commit comments

Comments
 (0)