Skip to content

Commit 665e2b6

Browse files
committed
front: fix warning in map
Signed-off-by: Clara Ni <[email protected]>
1 parent 676542a commit 665e2b6

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

front/src/common/Map/Layers/OSM.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ export function genOSMLayerProps(
5858
...acc,
5959
{
6060
...layer,
61-
key: `${layer.id}-${mapStyle}`,
6261
id: `osm/${layer.id}`,
6362
layerOrder,
6463
},
@@ -68,7 +67,7 @@ export function genOSMLayerProps(
6867

6968
export function genOSMLayers(mapStyle: string, toggledLayers: ToggledLayers, layerOrder?: number) {
7069
return genOSMLayerProps(mapStyle, toggledLayers, layerOrder).map((props) => (
71-
<OrderedLayer {...props} />
70+
<OrderedLayer key={`${props.id}-${mapStyle}`} {...props} />
7271
));
7372
}
7473

front/src/common/Map/WarpedMap/DataLoader.tsx

+7-8
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,10 @@ const DataLoader = ({ bbox, getGeoJSONs, layers }: DataLoaderProps) => {
5353
const osmStyle = (mapStyleJson as LayerProps[]).filter(
5454
(layer) => layer.id && OSM_LAYERS.has(layer.id)
5555
);
56-
return osmStyle
57-
.map((layer) => ({
58-
...layer,
59-
key: layer.id,
60-
id: `osm/${layer.id}`,
61-
}))
62-
.map((layer) => <OrderedLayer {...layer} />);
56+
return osmStyle.map((layer) => ({
57+
...layer,
58+
id: `osm/${layer.id}`,
59+
}));
6360
}, []);
6461

6562
useEffect(() => {
@@ -145,7 +142,9 @@ const DataLoader = ({ bbox, getGeoJSONs, layers }: DataLoaderProps) => {
145142
{state === 'render' && (
146143
<>
147144
<Source id="osm" type="vector" url={OSM_URL}>
148-
{osmLayers}
145+
{osmLayers.map((layer) => (
146+
<OrderedLayer key={layer.id} {...layer} />
147+
))}
149148
</Source>
150149
<GeoJSONs
151150
colors={colors[mapStyle]}

front/src/common/Map/WarpedMap/WarpedMap.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ const WarpedMap = ({
157157
data={osmData[sourceLayer] || featureCollection([])}
158158
>
159159
{layers.map((layer) => (
160-
<OrderedLayer {...(omit(layer, 'source-layer') as OrderedLayerProps)} />
160+
<OrderedLayer key={layer.id} {...(omit(layer, 'source-layer') as OrderedLayerProps)} />
161161
))}
162162
</Source>
163163
))}

0 commit comments

Comments
 (0)