front: be able to select a via on the map even when pf failed

Author: SarahBellaha

front/public/locales/en/operationalStudies/manageTrainSchedule.json

@@ -111,6 +111,7 @@
   "powerRestrictionExplanationText": "By default, the simulation will use the nominal power.",
   "powerRestrictionEmptyExplanationText": "The selected rolling stock does not have any power restrictions. You can edit it in the rolling stock editor.",
   "removeVia": "Remove this waypoint",
+  "requestedPoint": "Requested point",
   "restartPathfinding": "Restart search",
   "rollingstock": "Rolling stock",
   "saving": "Saving... please wait",

front/public/locales/fr/operationalStudies/manageTrainSchedule.json

@@ -112,6 +112,7 @@
   "powerRestrictionExplanationText": "Si aucune restriction de puissance n'est renseignée sur un intervalle, le calcul de marche sera réalisé en utilisant la puissance nominale.",
   "powerRestrictionEmptyExplanationText": "Le matériel roulant sélectionné ne possède pas de restrictions de puissance. Vous pouvez en créer dans l'éditeur de matériel roulant.",
   "removeVia": "Retirer ce via",
+  "requestedPoint": "Point demandé",
   "restartPathfinding": "Relancer la recherche",
   "rollingstock": "Matériel",
   "saving": "Enregistrement en cours... veuillez patienter",

front/src/modules/pathfinding/components/Itinerary/DisplayItinerary/v2/ViasV2.tsx

@@ -4,6 +4,7 @@ import { XCircle } from '@osrd-project/ui-icons';
 import cx from 'classnames';
 import type { Position } from 'geojson';
 import { DragDropContext, Droppable, Draggable } from 'react-beautiful-dnd';
+import { useTranslation } from 'react-i18next';
 import { useSelector } from 'react-redux';
 
 import { useOsrdConfActions, useOsrdConfSelectors } from 'common/osrdContext';
@@ -18,6 +19,7 @@ type DisplayViasV2Props = {
 };
 
 const ViasV2 = ({ zoomToFeaturePoint, shouldManageStopDuration }: DisplayViasV2Props) => {
+  const { t } = useTranslation('manageTrainSchedule');
   const { getViasV2 } = useOsrdConfSelectors();
   const dispatch = useAppDispatch();
   const vias = useSelector(getViasV2());
@@ -61,7 +63,7 @@ const ViasV2 = ({ zoomToFeaturePoint, shouldManageStopDuration }: DisplayViasV2P
                       >
                         <small className="font-weight-bold text-muted mr-1">{index + 1}</small>
                         <small data-testid="via-dropped-name" className="mr-1 text-nowrap">
-                          {`${via.name || `KM ${via.positionOnPath && (Math.round(via.positionOnPath) / 1000000).toFixed(3)}`}`}
+                          {`${via.name || (via.positionOnPath && `KM ${(Math.round(via.positionOnPath) / 1000000).toFixed(3)}`) || `${t('requestedPoint')} ${index + 1}`}`}
                         </small>
                         {via.ch && <small data-testid="via-dropped-ch">{via.ch}</small>}
                         {'uic' in via && (

front/src/modules/trainschedule/components/ManageTrainSchedule/ManageTrainScheduleMap/RenderPopup.tsx

@@ -29,11 +29,13 @@ type RenderPopupProps = {
 };
 
 function RenderPopup({ pathProperties }: RenderPopupProps) {
-  const { getFeatureInfoClick, getInfraID } = useOsrdConfSelectors();
+  const { getFeatureInfoClick, getInfraID, getOriginV2, getDestinationV2 } = useOsrdConfSelectors();
   const osrdConfActions = useOsrdConfActions();
   const { t } = useTranslation(['operationalStudies/manageTrainSchedule']);
   const featureInfoClick: FeatureInfoClickType = useSelector(getFeatureInfoClick);
   const infraId = useSelector(getInfraID);
+  const origin = useSelector(getOriginV2);
+  const destination = useSelector(getDestinationV2);
 
   const [trackOffset, setTrackOffset] = useState(0);
 
@@ -127,14 +129,18 @@ function RenderPopup({ pathProperties }: RenderPopupProps) {
           <RiMapPin2Fill />
           <span className="d-none">{t('origin')}</span>
         </button>
-        <button
-          className="btn btn-sm btn-info"
-          type="button"
-          onClick={() => setPointItiV2('via', pathStepProperties, osrdConfActions, pathProperties)}
-        >
-          <RiMapPin3Fill />
-          <span className="d-none">{t('via')}</span>
-        </button>
+        {origin && destination && (
+          <button
+            className="btn btn-sm btn-info"
+            type="button"
+            onClick={() =>
+              setPointItiV2('via', pathStepProperties, osrdConfActions, pathProperties)
+            }
+          >
+            <RiMapPin3Fill />
+            <span className="d-none">{t('via')}</span>
+          </button>
+        )}
         <button
           data-testid="map-destination-button"
           className="btn btn-sm btn-warning"

front/src/modules/trainschedule/components/ManageTrainSchedule/ManageTrainScheduleMap/setPointIti.ts

@@ -3,14 +3,17 @@ import type { ManageTrainSchedulePathProperties } from 'applications/operational
 import type { ConfSliceActions } from 'reducers/osrdconf/osrdConfCommon';
 import type { PathStep } from 'reducers/osrdconf/types';
 import { store } from 'store';
+import { addElementAtIndex } from 'utils/array';
 
 export function setPointItiV2(
   pointType: 'origin' | 'destination' | 'via',
   pathStep: PathStep,
   actions: ConfSliceActions,
   pathProperties?: ManageTrainSchedulePathProperties
 ) {
-  const { updateOriginV2, updateDestinationV2, addViaV2, updateFeatureInfoClick } = actions;
+  const { updateOriginV2, updateDestinationV2, addViaV2, updatePathSteps, updateFeatureInfoClick } =
+    actions;
+  const { pathSteps } = store.getState().operationalStudiesConf;
 
   switch (pointType) {
     case 'origin':
@@ -23,7 +26,11 @@ export function setPointItiV2(
       if (pathProperties) {
         store.dispatch(addViaV2({ newVia: pathStep, pathProperties }));
       } else {
-        console.error('No pathProperties');
+        store.dispatch(
+          updatePathSteps({
+            pathSteps: addElementAtIndex(pathSteps, pathSteps.length - 1, pathStep),
+          })
+        );
       }
   }
   store.dispatch(updateFeatureInfoClick({ displayPopup: false }));