fixup! editoast: derive: introduce Model error management and update trait Delete

Signed-off-by: Leo Valais <[email protected]>

Author: leovalais

editoast/editoast_models/src/model.rs

@@ -37,20 +37,9 @@ fn try_parse_unique_violation(
                 value: captures.get(2).unwrap().as_str().to_owned(),
             })
         } else {
-            tracing::error!(
-                ?RE,
-                error = e.message(),
-                details = e.details(),
-                "failed to parse PostgreSQL details message"
-            );
             None
         }
     } else {
-        tracing::error!(
-            ?RE,
-            error = e.message(),
-            "failed to parse PostgreSQL error message"
-        );
         None
     }
 }
@@ -67,11 +56,6 @@ fn try_parse_check_violation(e: &Box<dyn DatabaseErrorInformation + Send + Sync>
                 .to_owned(),
         })
     } else {
-        tracing::error!(
-            ?RE,
-            error = e.message(),
-            "failed to parse PostgreSQL error message"
-        );
         None
     }
 }
@@ -80,14 +64,22 @@ impl From<diesel::result::Error> for Error {
     fn from(e: diesel::result::Error) -> Self {
         match &e {
             diesel::result::Error::DatabaseError(DatabaseErrorKind::UniqueViolation, inner) => {
-                try_parse_unique_violation(inner).unwrap_or_else(|| {
+                try_parse_unique_violation(inner).unwrap_or_else(move || {
                     // falling back to the generic error — since it's still semantically correct, logging the error is enough
+                    tracing::error!(
+                        error = %e,
+                        "failed to parse PostgreSQL details message"
+                    );
                     Self::DatabaseError(e)
                 })
             }
             diesel::result::Error::DatabaseError(DatabaseErrorKind::CheckViolation, inner) => {
                 try_parse_check_violation(inner).unwrap_or_else(|| {
                     // falling back to the generic error — since it's still semantically correct, logging the error is enough
+                    tracing::error!(
+                        error = %e,
+                        "failed to parse PostgreSQL details message"
+                    );
                     Self::DatabaseError(e)
                 })
             }