scripts: fix shellcheck error and warnings

Author: Synar

.github/scripts/check-commit-titles.sh

@@ -1,12 +1,12 @@
 #!/bin/sh
+# shellcheck disable=SC2317
 
 # This script reads newline separated commit titles from stdin
 # output an error message when titles are deemed invalid,
 # and exits accordingly
 
 if [ -z "$NOCOLOR" ]; then
     RED=$(tput setaf 1 2>/dev/null)
-    YELLOW=$(tput setaf 3 2>/dev/null)
     BLUE=$(tput setaf 4 2>/dev/null)
     RESET=$(tput sgr0 2>/dev/null)
 fi

.github/workflows/build.yml

@@ -202,6 +202,8 @@ jobs:
 
       - name: Find and check all scripts using ShellCheck
         uses: ludeeus/action-shellcheck@master
+        with:
+          ignore_names: gradlew
 
   check_generated_railjson_sync:
     runs-on: ubuntu-latest

editoast/assets/signal_sprites/generate-atlas.sh

@@ -20,7 +20,8 @@ for signaling_system in $(ls); do
   cp "${tmp_dir}"/sprites/sprites* "${signaling_system}"
 
   # Add a linefeed to the json files
-  for json_file in $(ls  "${signaling_system}"/*.json); do
+  for json_file in "${signaling_system}"/*.json; do
+  [ -e "$json_file" ] || continue
     echo "" >> "${json_file}"
   done
 

scripts/drop-core.sh

@@ -1,8 +1,8 @@
 #!/bin/sh
 
-docker rm -f dyn-osrd-core-$1
+docker rm -f "dyn-osrd-core-$1"
 
 docker compose \
     -p "osrd" \
     -f "docker-compose.yml" \
-    exec rabbitmq rabbitmqctl delete_queue core-$1
+    exec rabbitmq rabbitmqctl delete_queue "core-$1"

scripts/load-backup.sh

@@ -14,7 +14,7 @@ if [ "$#" -ne 1 ]; then
   exit 1
 fi
 
-root_path="$(realpath $(dirname "$0")/..)"
+root_path=$(realpath "$(dirname "$0")/..")
 
 # Check sha1 is matching
 echo "Checking backup integrity..."