front: edition - fixing issues (#2614)

* front: editor - adding tooltip on button to select a tracksection on the map #2503

* front: editor - fix issue when clicking on button 'select a tracksection' and you hovera signal for example (bug 4-bis in #2503)

* front: editor - when changing the position of a signal in the form, the item is also moved on the map

* front: editor - fix new entity popin by not displaying default id &
click on line for signals

Author: sim51

front/public/locales/fr/translation.json

@@ -99,7 +99,9 @@
         "label": "Outil \"Aiguillage\",",
         "actions": {
           "delete-switch": "Supprimer l'aiguillage",
-          "new-switch": "Créer un nouvel aiguillage"
+          "new-switch": "Créer un nouvel aiguillage",
+          "pick-track": "Outil de sélection d'une ligne sur la carte",
+          "pick-track-cancel": "Annuler la sélection d'une ligne"
         },
         "help": {
           "no-move": "Les aiguillages ne peuvent pas être déplacer, et sont automatiquement placés sur leur premier port.",

front/src/applications/editor/Map.tsx

@@ -128,12 +128,11 @@ const MapUnplugged: FC<PropsWithChildren<MapProps>> = ({
                   ? editorState.entitiesIndex[feature.properties.id]
                   : undefined;
                 partialToolState.hovered = entity || null;
+                setToolState({ ...toolState, ...partialToolState });
               }
             } else if (activeTool.onMove) {
               activeTool.onMove(e, extendedContext);
             }
-
-            setToolState({ ...toolState, ...partialToolState });
             setMapState((prev) => ({ ...prev, ...partialMapState }));
           }}
           onLoad={(e) => {

front/src/applications/editor/components/EntitySumUp.tsx

@@ -3,6 +3,7 @@ import { useTranslation } from 'react-i18next';
 import { flatMap, uniq } from 'lodash';
 import cx from 'classnames';
 
+import { NEW_ENTITY_ID } from '../data/utils';
 import {
   BufferStopEntity,
   EditorEntity,
@@ -128,7 +129,7 @@ const EntitySumUp: FC<{
     <div>
       <div className={cx(classes.muted, classes.small)}>{type}</div>
       <div>
-        <span className={classes.strong}>{text}</span>
+        {text !== NEW_ENTITY_ID && <span className={classes.strong}>{text}</span>}
         {status && ` (${t(`Editor.item-statuses.${status}`)})`}
       </div>
       {subtexts.map((s, i) => (

front/src/applications/editor/tools/pointEdition/components.tsx

@@ -71,7 +71,7 @@ export const PointEditionLeftPanel: FC = <Entity extends EditorEntity>() => {
 
         const newPosition = entity.properties?.position;
         const oldPosition = state.entity.properties?.position;
-        const trackId = entity.properties?.track?.id;
+        const trackId = entity.properties?.track;
         if (
           typeof trackId === 'string' &&
           typeof newPosition === 'number' &&

front/src/applications/editor/tools/switchEdition/components.tsx

@@ -11,6 +11,7 @@ import { featureCollection, point } from '@turf/helpers';
 import nearestPoint from '@turf/nearest-point';
 
 import EditorContext from '../../context';
+import Tipped from '../../components/Tipped';
 import { ExtendedEditorContextType, OSRDConf } from '../types';
 import {
   CreateEntityOperation,
@@ -141,14 +142,23 @@ export const TrackSectionEndpointSelector: FC<FieldProps> = ({
             </div>
           )}
         </div>
-        <button
-          type="button"
-          className="btn btn-primary px-3"
-          onClick={startPickingPort}
-          disabled={isDisabled}
-        >
-          {isPicking ? <FaTimesCircle /> : <FaMapMarkedAlt />}
-        </button>
+        <Tipped mode="left">
+          <button
+            type="button"
+            className="btn btn-primary px-3"
+            onClick={startPickingPort}
+            disabled={isDisabled}
+          >
+            {isPicking ? <FaTimesCircle /> : <FaMapMarkedAlt />}
+          </button>
+          <span>
+            {t(
+              `Editor.tools.switch-edition.actions.${
+                isPicking ? 'pick-track-cancel' : 'pick-track'
+              }`
+            )}
+          </span>
+        </Tipped>
       </div>
     </div>
   );
@@ -305,9 +315,10 @@ export const SwitchEditionLayers: FC = () => {
   const nameLayerProps = getSwitchesNameLayerProps({
     colors: colors[mapStyle],
   });
-  const hoveredTrack = hovered
-    ? (entitiesIndex[hovered.properties.id] as TrackSectionEntity)
-    : null;
+  const hoveredTrack =
+    hovered && hovered.objType === 'TrackSection'
+      ? (entitiesIndex[hovered.properties.id] as TrackSectionEntity)
+      : null;
 
   const closest =
     portEditionState.type === 'selection' && hoveredTrack && mousePosition