editoast: merge branch 'dev'

Author: hamz2a

core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/Envelope.java

@@ -186,7 +186,6 @@ public double maxSpeedInRange(double beginPos, double endPos) {
     }
 
     private long interpolateUS(double position, boolean isArrivalAt) {
-        assert continuous : "interpolating times on a non continuous envelope is a risky business";
         var envelopePartIndex = findLeft(position);
         assert envelopePartIndex >= 0 : "Trying to interpolate time outside of the envelope";
         var envelopePart = get(envelopePartIndex);

core/osrd-reporting/src/main/java/fr/sncf/osrd/reporting/exceptions/ErrorType.java

@@ -152,7 +152,8 @@ public enum ErrorType {
     InconsistentSpeedSection(
             "speed_section",
             "Speed section definition is nonsensical and cannot be used for simulation",
-            ErrorCause.USER);
+            ErrorCause.USER),
+    MissingLastSTDCMStop("missing_last_stdcm_stop", "Last step of stdcm request needs to be a stop", ErrorCause.USER);
 
     public final String type;
     public final String message;

core/src/main/kotlin/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt

@@ -16,6 +16,7 @@ import fr.sncf.osrd.envelope_sim_infra.EnvelopeTrainPath
 import fr.sncf.osrd.envelope_sim_infra.MRSP
 import fr.sncf.osrd.graph.Pathfinding
 import fr.sncf.osrd.graph.PathfindingEdgeLocationId
+import fr.sncf.osrd.reporting.exceptions.ErrorType
 import fr.sncf.osrd.reporting.exceptions.OSRDError
 import fr.sncf.osrd.reporting.warnings.DiagnosticRecorderImpl
 import fr.sncf.osrd.sim_infra.api.Block
@@ -35,7 +36,6 @@ import fr.sncf.osrd.utils.units.Offset
 import fr.sncf.osrd.utils.units.meters
 import fr.sncf.osrd.utils.units.seconds
 import java.time.Duration.ofMillis
-import java.util.HashSet
 import org.takes.Request
 import org.takes.Response
 import org.takes.Take
@@ -174,7 +174,9 @@ class STDCMEndpointV2(private val infraManager: InfraManager) : Take {
 }
 
 private fun parseSteps(infra: FullInfra, pathItems: List<STDCMPathItem>): List<STDCMStep> {
-    assert(pathItems.last().stopDuration != null)
+    if (pathItems.last().stopDuration == null) {
+        throw OSRDError(ErrorType.MissingLastSTDCMStop)
+    }
     return pathItems
         .map {
             STDCMStep(