front: editor-slopes-fix-form-validation

Remove local errors check in slopes form and let global form validate the form

Author: Wadjetz

front/src/applications/editor/components/LinearMetadata/FormComponent.tsx

@@ -108,7 +108,7 @@ export const FormComponent: React.FC<FieldProps> = (props) => {
 
   const customOnChange = useCallback(
     (newData: Array<LinearMetadataItem>) => {
-      onChange(newData.filter((e) => (valueField ? !isNil(e[valueField]) : true)));
+      onChange(valueField === "gradient" ? newData : newData.filter((e) => (valueField ? !isNil(e[valueField]) : true)))
     },
     [onChange, valueField]
   );
@@ -363,43 +363,41 @@ export const FormComponent: React.FC<FieldProps> = (props) => {
                 }}
                 formData={selectedData}
                 onChange={(e) => {
-                  if (e.errors.length === 0) {
-                    const newItem = e.formData;
-                    const oldItem = data[selected];
-                    let newData = [...data];
-                    // we keep the old value for begin and end
-                    // they will be change in the resize function if needed
-                    newData[selected] = {
-                      ...oldItem,
-                      ...omit(newItem, ['begin', 'end']),
-                    };
+                  const newItem = e.formData;
+                  const oldItem = data[selected];
+                  let newData = [...data];
+                  // we keep the old value for begin and end
+                  // they will be change in the resize function if needed
+                  newData[selected] = {
+                    ...oldItem,
+                    ...omit(newItem, ['begin', 'end']),
+                  };
 
-                    // Check if there is a resize
-                    try {
-                      if (newItem.begin !== oldItem.begin) {
-                        const resizeBegin = resizeSegment(
-                          [...newData],
-                          selected,
-                          newItem.begin - oldItem.begin,
-                          'begin'
-                        );
-                        newData = resizeBegin.result;
-                      }
-                      if (oldItem.end !== newItem.end) {
-                        const resizeEnd = resizeSegment(
-                          [...newData],
-                          selected,
-                          newItem.end - oldItem.end,
-                          'end'
-                        );
-                        newData = resizeEnd.result;
-                      }
-                      customOnChange(newData);
-                    } catch (error) {
-                      // TODO: Should we display the resize error ?
-                    } finally {
-                      setSelectedData(newItem);
+                  // Check if there is a resize
+                  try {
+                    if (newItem.begin !== oldItem.begin) {
+                      const resizeBegin = resizeSegment(
+                        [...newData],
+                        selected,
+                        newItem.begin - oldItem.begin,
+                        'begin'
+                      );
+                      newData = resizeBegin.result;
+                    }
+                    if (oldItem.end !== newItem.end) {
+                      const resizeEnd = resizeSegment(
+                        [...newData],
+                        selected,
+                        newItem.end - oldItem.end,
+                        'end'
+                      );
+                      newData = resizeEnd.result;
                     }
+                    customOnChange(newData);
+                  } catch (error) {
+                    // TODO: Should we display the resize error ?
+                  } finally {
+                    setSelectedData(newItem);
                   }
                 }}
               >