editoast_derive: clippy fixes

Author: leovalais

editoast/editoast_derive/src/error.rs

@@ -26,8 +26,8 @@ struct ParsedVariant {
     fields: Fields,
 }
 
-pub fn expand_editoast_error(input: &mut DeriveInput) -> Result<TokenStream> {
-    let options = ErrorOptions::from_derive_input(&input)?;
+pub fn expand_editoast_error(input: &DeriveInput) -> Result<TokenStream> {
+    let options = ErrorOptions::from_derive_input(input)?;
 
     let name = &input.ident;
     let base_id = options.base_id;
@@ -36,7 +36,7 @@ pub fn expand_editoast_error(input: &mut DeriveInput) -> Result<TokenStream> {
         syn::Data::Enum(data) => data,
         _ => return Err(Error::custom("EditoastError: Only enums are supported.")),
     };
-    let variants = parse_variants(&enum_data)?;
+    let variants = parse_variants(enum_data)?;
 
     let get_statuses = expand_get_statuses(
         &variants,
@@ -84,7 +84,7 @@ fn parse_variants(enum_data: &DataEnum) -> Result<Vec<ParsedVariant>> {
     Ok(variants)
 }
 
-fn expand_get_statuses(variants: &Vec<ParsedVariant>, default_status: u16) -> Result<TokenStream> {
+fn expand_get_statuses(variants: &[ParsedVariant], default_status: u16) -> Result<TokenStream> {
     let match_variants = variants.iter().map(|variant| {
         let ident = &variant.ident;
         quote! {#ident {..}}
@@ -102,7 +102,7 @@ fn expand_get_statuses(variants: &Vec<ParsedVariant>, default_status: u16) -> Re
     })
 }
 
-fn expand_get_types(variants: &Vec<ParsedVariant>, base_id: String) -> TokenStream {
+fn expand_get_types(variants: &[ParsedVariant], base_id: String) -> TokenStream {
     let match_variants = variants.iter().map(|variant| {
         let ident = &variant.ident;
         quote! {#ident {..}}
@@ -119,7 +119,7 @@ fn expand_get_types(variants: &Vec<ParsedVariant>, base_id: String) -> TokenStre
     }
 }
 
-fn expand_contexts(variants: &Vec<ParsedVariant>) -> TokenStream {
+fn expand_contexts(variants: &[ParsedVariant]) -> TokenStream {
     let context = variants.iter().map(|variant| {
         let ident = &variant.ident;
         let no_context = variant.params.no_context.unwrap_or(false);

editoast/editoast_derive/src/lib.rs

@@ -51,8 +51,8 @@ pub fn infra_model(input: proc_macro::TokenStream) -> proc_macro::TokenStream {
 /// ```
 #[proc_macro_derive(EditoastError, attributes(editoast_error))]
 pub fn error(input: TokenStream) -> TokenStream {
-    let mut input = parse_macro_input!(input as DeriveInput);
-    error::expand_editoast_error(&mut input)
+    let input = parse_macro_input!(input as DeriveInput);
+    error::expand_editoast_error(&input)
         .unwrap_or_else(darling::Error::write_errors)
         .into()
 }
@@ -88,8 +88,8 @@ pub fn error(input: TokenStream) -> TokenStream {
 ///   - Insertable (for **create**)
 #[proc_macro_derive(Model, attributes(model))]
 pub fn model(input: proc_macro::TokenStream) -> proc_macro::TokenStream {
-    let mut input = parse_macro_input!(input as DeriveInput);
-    model::model(&mut input)
+    let input = parse_macro_input!(input as DeriveInput);
+    model::model(&input)
         .unwrap_or_else(darling::Error::write_errors)
         .into()
 }

editoast/editoast_derive/src/model.rs

@@ -40,8 +40,8 @@ impl Config {
     }
 }
 
-pub fn model(input: &mut DeriveInput) -> Result<TokenStream> {
-    let options = ModelOptions::from_derive_input(&input).expect("Model: bad options");
+pub fn model(input: &DeriveInput) -> Result<TokenStream> {
+    let options = ModelOptions::from_derive_input(input).expect("Model: bad options");
     let model_name = &input.ident;
     let config = Config::new(model_name.clone(), &options);