Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage paced trains #10615

Open
12 tasks
SharglutDev opened this issue Jan 31, 2025 · 0 comments
Open
12 tasks

Manage paced trains #10615

SharglutDev opened this issue Jan 31, 2025 · 0 comments
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:feature-task Work related to a feature epic module:operational-studies Multi-train simulation with structured studies management

Comments

@SharglutDev
Copy link
Contributor

SharglutDev commented Jan 31, 2025

Description and goal

Be able to creating (back connection), edit, duplicate and deleting a paced train.

A unique train can be converted into a paced train and vice versa.

Ppt mockup here : https://sncf.sharepoint.com/:p:/r/sites/OSRD644GrpO365/Documents%20partages/PO/Groupes%20et%20familles%20de%20trains/Maquette%20mission%20PI14.pptx?d=wfceedf5d80034b0aaed5e9ba4dff9dfd&csf=1&web=1&e=Tbb4nc

skecth mockup : https://www.sketch.com/s/2fb064cd-c483-46ac-bd30-72705fd63e75/a/YZkJDEv

This feature should have e2e tests.

End to end tests strategy

Create (sequel of tests in #10607)

  • click on add paced train button
  • verify that a success toast is displayed
  • verify the count ( 1 mission is displayed)
  • verify in the timetable that the new paced train is there
  • depending on the duration and cadence verify the number of occurrences (counter in main paced train card and number of occurrence cards)
  • verify the rolling stock icon only displayed for the main paced train card
  • verify the start time of each occurrence
  • project an occurence and verify that the gev, get ... are displayed
  • delete the paced train (API)

Add/Delete Multiple occurrences

  • create a paced train with a numeric name
  • verify the numbers grows from 2 to 2. ex: 8602 - 8602 > 8604 > 8606...
  • verify the count ( 1 mission is displayed)
  • create a new paced train with a name that is a string ending in a separated number
  • verify the numbers incrementing by 2 ex: Lyon 1 - Lyon 1 > Lyon 3 > Lyon 5...
  • verify the count ( 2 mission is displayed)
  • create a new paced train with a name that is a string ending with a numbero
  • verify the numbers incrementing by 2 . ex: tgv2024 - tgv2024 1 > tgv2024 3 > tgv2024 5...
  • verify the count ( 3 mission is displayed)
  • create a new paced train with a regular string name
  • verify the numbers growing by 2 to 2 (same as before). ex : freight - freight 1 > freight 3 > freight 5...
  • verify the count ( 4 mission is displayed)
  • check the checkbox to select all the paced train
  • click on delete button on the paced train card in timetable
  • verify the toast message
  • verify that it's not in the timetable anymore

Edit

  • click on edit button on the paced train card in timetable
  • check that the edit paced train button shows Edit service
  • check that the checkbox is checked and custom inputs are there
  • check for customs edit button names if unchecking the checkbox
  • change the duration and cadence and verify the values
  • change start time, the name and RS
  • edit the paced train
  • verify the toast message
  • depending on the duration and cadence verify the number of occurrences (counter in main paced train card and number of occurrence cards)
  • verify the rolling stock icon only displayed for the main paced train card is updated
  • verify the start time of each occurrence
  • verify occurrence names
  • project an occurence and verify that the gev, get ... are displayed
  • delete the paced train (API)

Duplicate

  • click on duplicate button on the paced train card in timetable
  • verify that a new one has been added
  • check number of occurences in paced train card and number of occurrence cards
  • verify the new paced train name
  • delete both trains (API)

Delete single paced train

  • create a paced train (API)
  • click on delete button on the paced train card in timetable
  • verify the toast message
  • verify that it's not in the timetable anymore

Filter trains

  • update the test 008-train-schedule.spec.ts ( add 2 paced trains in the train schedule)
  • update the values for the new train schedule
  • filter train by type
  • verify that only the selected type are displayed

Acceptance criteria

  • When editing a paced train, the checkbox is check and we can see its specific fields
  • When editing a paced train, the edit button shows Edit service ("Modifier la mission")
  • When editing a paced train, if the checkbox is unchecked, the button shows Turn this service into a train ("Transformer cette mission en train")
  • When editing a unique train, the edit button shows Edit train ("Modifier le train")
  • When editing a unique train, if the checkbox is checked, the button shows Turn this train into a service ("Transformer ce train en mission")
  • When editing a paced train, its custom fields keep their values if multi switching from paced train / unique trains
  • Changing the cadence will update the number of occurence in the timetable and space time chart
  • When adding a paced train, the occurrence name are generated following the pattern in the description
  • Adding a paced train with a duration of 120min and cadence of 30min generates 4 occurrences (120 / 30 rounded to bottom)
  • Duplicating a paced train increase the start time of the new one by 5min and its name follow the current unique train behavior
  • Deleting a paced train deletes it and all of its occurrences
  • Add e2e tests following the above strategy
@Maymanaf Maymanaf mentioned this issue Feb 3, 2025
10 tasks
@SharglutDev SharglutDev self-assigned this Feb 26, 2025
@SharglutDev SharglutDev added area:front Work on Standard OSRD Interface modules kind:feature-task Work related to a feature epic module:operational-studies Multi-train simulation with structured studies management labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:feature-task Work related to a feature epic module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
Development

No branches or pull requests

1 participant