front: undefined fetchedSections when opening a scenario

[emersion]

What happened?

Failed to fetch track sections: TypeError: fetchedSections is undefined
    getTrackSectionsByIds useCachedTrackSections.ts:26
    getPathItemsCoordinates SimulationResultsMap.tsx:75
    SimulationResultMap SimulationResultsMap.tsx:100

What did you expect to happen?

No response

How can we reproduce it (as minimally and precisely as possible)?

Open/close a scenario until the error pops up.

On which environments the bug occurs?

Local

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

3ebcea2

[emersion]

cc @Synar

There is a weird rtk-query interaction going on: loadInfraObject() returns undefined. It seems to happen when fetching a large number of track sections.

• Multiple requests are running in parallel, and the first sent request may complete last if it queried many track sections.
• useLazyQuery() shouldn't be used there, initiate() should be used instead. But fixing that doesn't fix the issue.
• Turning the request into a mutation makes the error go away. This leads me to believe rtk-query's caching mechanism is involved somehow.
• Disabling the cache (by setting serializeQueryArgs, merge and forceRefetch) also fixes the issue, but results in tracks[id] being undefined down the line…

Turn the query into a mutation

diff --git a/front/src/common/api/generatedEditoastApi.ts b/front/src/common/api/generatedEditoastApi.ts
index 54a71ad94117..c11ca2f3e95d 100644
--- a/front/src/common/api/generatedEditoastApi.ts
+++ b/front/src/common/api/generatedEditoastApi.ts
@@ -293,7 +293,7 @@ const injectedRtkApi = api
         query: (queryArg) => ({ url: `/infra/${queryArg.infraId}/lock`, method: 'POST' }),
         invalidatesTags: ['infra'],
       }),
-      postInfraByInfraIdObjectsAndObjectType: build.query<
+      postInfraByInfraIdObjectsAndObjectType: build.mutation<
         PostInfraByInfraIdObjectsAndObjectTypeApiResponse,
         PostInfraByInfraIdObjectsAndObjectTypeApiArg
       >({
@@ -302,7 +302,7 @@ const injectedRtkApi = api
           method: 'POST',
           body: queryArg.body,
         }),
-        providesTags: ['infra'],
+        invalidatesTags: ['infra'],
       }),
       postInfraByInfraIdPathProperties: build.query<
         PostInfraByInfraIdPathPropertiesApiResponse,
diff --git a/front/src/config/openapi-editoast-config.cts b/front/src/config/openapi-editoast-config.cts
index dd5f3cd7b714..9da0396a938a 100644
--- a/front/src/config/openapi-editoast-config.cts
+++ b/front/src/config/openapi-editoast-config.cts
@@ -11,7 +11,7 @@ const config: ConfigFile = {
   endpointOverrides: [
     {
       pattern: [
-        'postInfraByInfraIdObjectsAndObjectType',
+        //'postInfraByInfraIdObjectsAndObjectType',
         'postInfraByInfraIdPathfinding',
         'postInfraByInfraIdPathfindingBlocks',
         'postInfraByInfraIdPathProperties',

Disable the cache

diff --git a/front/src/applications/operationalStudies/hooks/useCachedTrackSections.ts b/front/src/applications/operationalStudies/hooks/useCachedTrackSections.ts
index d22001606e10..ab8ae11697e2 100644
--- a/front/src/applications/operationalStudies/hooks/useCachedTrackSections.ts
+++ b/front/src/applications/operationalStudies/hooks/useCachedTrackSections.ts
@@ -1,26 +1,31 @@
-import { useRef, useCallback } from 'react';
+import { useRef, useCallback, useState } from 'react';
 
 import { uniq } from 'lodash';
 
 import { osrdEditoastApi } from 'common/api/osrdEditoastApi';
 import type { TrackSection } from 'common/api/osrdEditoastApi';
+import { useAppDispatch } from 'store';
 
 export default function useCachedTrackSections(infraId: number) {
   const trackIdsRef = useRef<Set<string>>(new Set());
   const trackSectionsRef = useRef<Record<string, TrackSection>>({});
-  const [loadInfraObject, { isLoading }] =
-    osrdEditoastApi.endpoints.postInfraByInfraIdObjectsAndObjectType.useLazyQuery();
+  const [isLoading, setIsLoading] = useState(false);
+  const dispatch = useAppDispatch();
 
   const getTrackSectionsByIds = useCallback(
     async (requestedTrackIds: string[]) => {
       const uniqueNewIds = uniq(requestedTrackIds.filter((id) => !trackIdsRef.current.has(id)));
       if (uniqueNewIds.length !== 0) {
+        setIsLoading(true);
         try {
-          const fetchedSections = await loadInfraObject({
+          console.log('start', uniqueNewIds);
+          const promise = dispatch(osrdEditoastApi.endpoints.postInfraByInfraIdObjectsAndObjectType.initiate({
             infraId,
             objectType: 'TrackSection',
             body: uniqueNewIds,
-          }).unwrap();
+          }, { subscribe: false }));
+          const fetchedSections = await promise.unwrap();
+          console.log('done', fetchedSections, uniqueNewIds);
 
           uniqueNewIds.forEach((id) => trackIdsRef.current.add(id));
           fetchedSections.forEach((rawSection) => {
@@ -29,6 +34,8 @@ export default function useCachedTrackSections(infraId: number) {
           });
         } catch (error) {
           console.error('Failed to fetch track sections:', error);
+        } finally {
+          setIsLoading(false);
         }
       }
 
diff --git a/front/src/applications/operationalStudies/hooks/useScenarioData.ts b/front/src/applications/operationalStudies/hooks/useScenarioData.ts
index e2a0b6009dbd..0187a34d2ca3 100644
--- a/front/src/applications/operationalStudies/hooks/useScenarioData.ts
+++ b/front/src/applications/operationalStudies/hooks/useScenarioData.ts
@@ -45,13 +45,17 @@ const useScenarioData = (scenario: ScenarioResponse, infra: InfraWithState) => {
 
   const projectionPath = usePathProjection(infra);
 
-  const { data: trainSchedulesResults = [] } =
+  const { data: fetchTrainSchedulesResults } =
     osrdEditoastApi.endpoints.getAllTimetableByIdTrainSchedules.useQuery(
       { timetableId: scenario?.timetable_id },
       {
         skip: !scenario,
       }
     );
+  const trainSchedulesResults = useMemo(
+    () => fetchTrainSchedulesResults || [],
+    [fetchTrainSchedulesResults]
+  );
 
   const { trainScheduleSummariesById, setTrainScheduleSummariesById, allTrainsLoaded } =
     useLazyLoadTrains({
diff --git a/front/src/common/api/osrdEditoastApi.ts b/front/src/common/api/osrdEditoastApi.ts
index d6354e319b13..5b11d488eb8e 100644
--- a/front/src/common/api/osrdEditoastApi.ts
+++ b/front/src/common/api/osrdEditoastApi.ts
@@ -165,6 +165,12 @@ const osrdEditoastApi = generatedEditoastApi
           { type: 'scenarios', id: 'LIST' },
         ],
       },
+
+      postInfraByInfraIdObjectsAndObjectType: {
+        serializeQueryArgs: ({ endpointName }) => endpointName,
+        merge: () => {},
+        forceRefetch: () => true,
+      },
     },
   });