Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all React warnings during execution #1959

Closed
1 of 10 tasks
alexandredamiron opened this issue Sep 26, 2022 · 1 comment
Closed
1 of 10 tasks

Remove all React warnings during execution #1959

alexandredamiron opened this issue Sep 26, 2022 · 1 comment
Assignees
@alexandredamiron @anisometropie
Labels
area:front Work on Standard OSRD Interface modules

Comments

@alexandredamiron
Copy link
Contributor

alexandredamiron commented Sep 26, 2022 •
edited
Loading

Description

We have react warning on each modules about key-props or no cleanup functions for unmounting

Goal

Clean that

Acceptance criteria

  • No warning at leas ton init for /settings, /simulation, /stdcm routes

Definition of ready

  • The user story is well defined
  • Acceptance criterias are defined
  • The individual responsible for validating the user story is assigned
  • The team should understand how to demonstrate the features
  • Does not depend on an missing feature
  • Negociable with the implementation team
  • Valuable to the end users
  • Estimable by the implementation team
  • As small as it can be
@anisometropie anisometropie mentioned this issue Sep 27, 2022
Merged
@alexandredamiron
Copy link
Contributor Author

Attention, on /stdcm and /simulation and /settings modules/routes ! WIP in editor

@axrolld axrolld closed this as completed Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandredamiron alexandredamiron

@anisometropie anisometropie

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexandredamiron @anisometropie @axrolld