Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: the block generator does not ensure routes are bounded by appropriate signals #4606

Closed
multun opened this issue Jul 18, 2023 · 0 comments · Fixed by #10426
Closed

core: the block generator does not ensure routes are bounded by appropriate signals #4606

multun opened this issue Jul 18, 2023 · 0 comments · Fixed by #10426
Assignees
Labels
area:core Work on Core Service difficulty:good first issue Good for newcomers kind:bug Something isn't working severity:minor Minor severity bug

Comments

@multun
Copy link
Contributor

multun commented Jul 18, 2023

What happened?

In the real world, only some signals can be used to end / start routes. These signal cannot be passed when closed due to interlocking (Nf signals in french signaling).

Currently, we let block delimiting signals start and end routes, regardless of whether they can actually signal for the end of a route.

What did you expect to happen?

We should check whether signals at the end / start of routes are actually belong there, and raise a warning if they don't.

In practice, the is_route_delimiter property is missing from the current implementation.

How can we reproduce it (as minimally and precisely as possible)?

  1. Create a route which ends with a non-route delimiting signal
  2. No warning whatsoever

What operating system, browser and environment are you using?

  • Browser: Firefox v109
  • OS: Nixos v22.11
  • Env: Local

OSRD version (top right corner Account button > Informations)

2421cbd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service difficulty:good first issue Good for newcomers kind:bug Something isn't working severity:minor Minor severity bug
Projects
None yet
2 participants