Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: map: LGV Signals are not properly displayed #4901

Closed
nicolaswurtz opened this issue Aug 25, 2023 · 2 comments
Closed

front: map: LGV Signals are not properly displayed #4901

nicolaswurtz opened this issue Aug 25, 2023 · 2 comments
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working severity:minor Minor severity bug

Comments

@nicolaswurtz
Copy link
Contributor

nicolaswurtz commented Aug 25, 2023

As the title says...

Image

@nicolaswurtz nicolaswurtz added area:front Work on Standard OSRD Interface modules severity:minor Minor severity bug labels Aug 25, 2023
@sim51
Copy link
Contributor

sim51 commented Aug 30, 2023

@nicolaswurtz I don't really know how to display those signals, but by adding a case 'REP TGV': here https://github.com/osrd-project/osrd/blob/dev/front/src/common/Map/Layers/geoSignalsLayers.ts#L448 , I have something better.

Code extract :

switch (type) {
    case 'REPER VIT':
    case 'REP TGV':
      return getSignalEmptyLayerProps(context, type, iconOffset, 'extensions_sncf_label');
   ....

image

I don't know if it's the desired design, or if we have to write a new getSignalXXXLayerProps function.

@clarani clarani added the kind:bug Something isn't working label Sep 21, 2023
@clarani clarani assigned flomonster and Akctarus and unassigned flomonster Oct 23, 2023
@clarani
Copy link
Contributor

clarani commented Oct 23, 2023

Solved by #5166

@clarani clarani closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working severity:minor Minor severity bug
Projects
None yet
Development

No branches or pull requests

5 participants