Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite computing when creating new route #5543

Closed
axrolld opened this issue Oct 31, 2023 · 5 comments · Fixed by #5904
Closed

Infinite computing when creating new route #5543

axrolld opened this issue Oct 31, 2023 · 5 comments · Fixed by #5904
Assignees
Labels
area:editoast Work on Editoast Service kind:bug Something isn't working module:infra-editor Infra Edition severity:critical Critical severity bug

Comments

@axrolld
Copy link
Contributor

axrolld commented Oct 31, 2023

What happened?

I'm trying to fix a hole in the infrastructure so i created a track link and now i want to add a new route, but looking for compatible routes between start and stop has been computing for 5mn without finding anything
image

What did you expect to happen?

It should either find a route or return an error.

How can we reproduce it (as minimally and precisely as possible)?

  1. Go to infra editor
  2. Select France_en_qualite
  3. Try to create a new route between this detector
    image
    And this one
    image

What operating system, browser and environment are you using?

  • Browser: Chrome
  • OS: Win 11
  • Env: staging

OSRD version (top right corner Account button > Informations)

1280353

@axrolld axrolld added the kind:bug Something isn't working label Oct 31, 2023
@axrolld
Copy link
Contributor Author

axrolld commented Oct 31, 2023

Edit: it appears that this bug came from an editoast crash (not 100% sure). But i can't reproduce it right now. This needs to be investigated.

@axrolld axrolld added severity:major Major severity bug module:infra-editor Infra Edition labels Oct 31, 2023
@sim51 sim51 added the area:editoast Work on Editoast Service label Nov 22, 2023
@younesschrifi
Copy link
Contributor

I've tried to reproduce this bug but it's impossible at the moment. As we discussed with @axrolld, it must have happened at a time when Editoast crashed.

@younesschrifi younesschrifi self-assigned this Nov 22, 2023
@axrolld
Copy link
Contributor Author

axrolld commented Nov 23, 2023

Bug reproduced on staging near Sète train station

Image

Image

@Tristramg
Copy link
Contributor

I can reproduce the bug.
Only in the infra editor, not in a simulation.
Editoast is at 100% CPU but in the end it finds a solution.

The pathfind makes a huge loop. The computation ends, but it takes a very long time and might timeout.
image

image

When asking a path starting in the inverse direction we find the solution we want.

image

Both detectors are ApplicableDirections=BOTH

The signals are all in the same direction at the station
image

image

@younesschrifi
Copy link
Contributor

younesschrifi commented Nov 28, 2023

suggestions:

  • add 2 additional limits on the number of steps and the maximum cost of the path
  • potentially remove the start direction field and have editoast find the best direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service kind:bug Something isn't working module:infra-editor Infra Edition severity:critical Critical severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants