Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Store TSV1 #8065

Closed
42 of 47 tasks
SharglutDev opened this issue Jul 15, 2024 · 0 comments · Fixed by #8382
Closed
42 of 47 tasks

Drop Store TSV1 #8065

SharglutDev opened this issue Jul 15, 2024 · 0 comments · Fixed by #8382
Assignees
@SharglutDev
Labels
area:front Work on Standard OSRD Interface modules

Comments

@SharglutDev
Copy link
Contributor

SharglutDev commented Jul 15, 2024 •
edited
Loading

Description and goal

Remove all code in store related to the old model

Actions to remove (not exhaustive):

  • updateViaStopTime
  • updateOrigin
  • updateDestination
  • addVias
  • permuteVias
  • deleteVias
  • replaceVias
  • clearVias
  • updatePathfindingID
  • updateSuggeredVias
  • updatePowerRestrictionRanges
  • updateAllowances
  • updateItinerary
  • deleteItinerary
  • updateDepartureTime
  • updateRollingStockComfortType
  • updateTrainScheduleIdToModify
  • updateDestinationTime (from old stdcm, not used anymore)
  • updateDestinationDate (from old stdcm, not used anymore)
  • updateSimulation (and all undo/redo etc)
  • updateSelectedProjection
  • updateAllowancesSettings
  • updateSpeedSpaceSettings
  • updateSignalBase

Selectors to remove (not exhaustive):

  • getVias
  • getOrigin
  • getDestination
  • getGeojson
  • getSuggeredVias
  • getPathfindingId
  • getPowerRestrictionRanges
  • getAllowances
  • getDepartureTime
  • getRollingStockComfortType
  • getTrainScheduleIdToModify
  • getDestinationTime (from old stdcm, not used anymore)
  • getDestinationDate (from old stdcm, not used anymore)
  • getSelectedProjection
  • getPresentSimulation
  • getAllowancesSettings
  • getSpeedSpaceSettings
  • getConsolidatedSimulation

Other:

  • simulation.ts

Acceptance criteria

  • Old types are removed
  • Old selectors are removed
  • Old actions are removed
  • Unused types in reducers/osrdsimulation are removed
  • Check all DROP TSV1 or TODO TS2
@SharglutDev SharglutDev added the area:front Work on Standard OSRD Interface modules label Jul 15, 2024
@SharglutDev SharglutDev self-assigned this Jul 15, 2024
@clarani clarani mentioned this issue Jul 29, 2024
Closed
3 tasks
@SharglutDev SharglutDev mentioned this issue Aug 8, 2024
Merged
@Tguisnet Tguisnet assigned Akctarus and unassigned SharglutDev Aug 9, 2024
@SharglutDev SharglutDev assigned SharglutDev and unassigned Akctarus Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SharglutDev SharglutDev

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

front: drop store related to tsv1 OpenRailAssociation/osrd
2 participants
@Akctarus @SharglutDev