Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: bad length passed to formatSuggestedOperationalPoints() #8725

Closed
emersion opened this issue Sep 3, 2024 · 2 comments
Closed

front: bad length passed to formatSuggestedOperationalPoints() #8725

emersion opened this issue Sep 3, 2024 · 2 comments
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management

Comments

@emersion
Copy link
Member

emersion commented Sep 3, 2024

What happened?

In front/src/modules/timesStops/hooks/useOutputTableData.ts, path.length is passed to formatSuggestedOperationalPoints(). This is then passed to getPointCoordinates(). However that function expects a position in millimeters, not an index.

What did you expect to happen?

.

How can we reproduce it (as minimally and precisely as possible)?

.

On which environments the bug occurs?

No response

On which browser the bug occurs?

No response

OSRD version (top right corner Account button > Informations)

53bd1e9
@emersion emersion added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management labels Sep 3, 2024
@emersion emersion mentioned this issue Sep 10, 2024
Open
@axrolld
Copy link
Contributor

axrolld commented Nov 13, 2024

@emersion how severe is this bug ?

@emersion
Copy link
Member Author

After further investigation it seems like path.length is actually a distance in mm instead of an array length. Sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emersion @axrolld